Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11635032: Added introductory tables to Chrome apps APIs. (Closed)

Created:
8 years ago by mkearney1
Modified:
8 years ago
Reviewers:
miket_OOO, saroop
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Added introductory tables to Chrome apps APIs. These tables include a description, when the API is available, the permissions, and links to learn more (both docs and GDL sessions). BUG=163374 BUG=163413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174282

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -129 lines) Patch
M chrome/common/extensions/docs/static/css/site.css View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/alarms.html View 1 2 1 chunk +24 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/app_runtime.html View 1 2 3 1 chunk +27 lines, -12 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/app_window.html View 1 2 3 4 1 chunk +30 lines, -15 lines 1 comment Download
M chrome/common/extensions/docs/templates/intros/bluetooth.html View 1 2 3 1 chunk +27 lines, -8 lines 1 comment Download
M chrome/common/extensions/docs/templates/intros/commands.html View 1 1 chunk +21 lines, -5 lines 1 comment Download
M chrome/common/extensions/docs/templates/intros/contextMenus.html View 1 2 chunks +31 lines, -16 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/fileSystem.html View 1 2 3 4 1 chunk +33 lines, -16 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/idle.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/mediaGalleries.html View 1 2 3 4 1 chunk +29 lines, -4 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/runtime.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/serial.html View 1 2 3 4 1 chunk +24 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/socket.html View 1 2 3 4 1 chunk +29 lines, -10 lines 2 comments Download
M chrome/common/extensions/docs/templates/intros/storage.html View 1 1 chunk +27 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/tts.html View 1 1 chunk +28 lines, -9 lines 1 comment Download
M chrome/common/extensions/docs/templates/intros/usb.html View 1 2 3 1 chunk +28 lines, -14 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/webstore.html View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/runtime.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/webstore.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/extensions/runtime.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/extensions/webstore.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
miket_OOO
lgtm https://chromiumcodereview.appspot.com/11635032/diff/2023/chrome/common/extensions/docs/static/css/site.css File chrome/common/extensions/docs/static/css/site.css (right): https://chromiumcodereview.appspot.com/11635032/diff/2023/chrome/common/extensions/docs/static/css/site.css#newcode322 chrome/common/extensions/docs/static/css/site.css:322: } Separate rules with new lines: http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=Rule_separation#Rule_separation https://chromiumcodereview.appspot.com/11635032/diff/2023/chrome/common/extensions/docs/static/css/site.css#newcode328 ...
8 years ago (2012-12-20 23:25:36 UTC) #1
mkearney1
https://chromiumcodereview.appspot.com/11635032/diff/2023/chrome/common/extensions/docs/static/css/site.css File chrome/common/extensions/docs/static/css/site.css (right): https://chromiumcodereview.appspot.com/11635032/diff/2023/chrome/common/extensions/docs/static/css/site.css#newcode322 chrome/common/extensions/docs/static/css/site.css:322: } On 2012/12/20 23:25:36, miket wrote: > Separate rules ...
8 years ago (2012-12-20 23:56:56 UTC) #2
saroop
Added comments. https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/extensions/docs/templates/intros/app_window.html File chrome/common/extensions/docs/templates/intros/app_window.html (right): https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/extensions/docs/templates/intros/app_window.html#newcode10 chrome/common/extensions/docs/templates/intros/app_window.html:10: Windows can either be shells or panels. ...
8 years ago (2012-12-21 00:39:44 UTC) #3
mkearney1
8 years ago (2012-12-21 21:42:33 UTC) #4
Message was sent while issue was closed. 
Hey, Sriram

I committed the cl just before I got your review comments (wanted to get this
out before the break).

I'll create an issue to put these changes through and cc you on the issue.

Meggin

On 2012/12/21 00:39:44, saroop wrote:
> Added comments.
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> File chrome/common/extensions/docs/templates/intros/app_window.html (right):
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> chrome/common/extensions/docs/templates/intros/app_window.html:10: Windows can
> either be shells or panels.
> The API reference does not talk abt how to create a shell window vs a panel
> window. Can we include that info in the API reference ?
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> File chrome/common/extensions/docs/templates/intros/bluetooth.html (right):
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> chrome/common/extensions/docs/templates/intros/bluetooth.html:16:
> <td><strong>Availability:</strong></td>
> Should we also mention that this does not work for Windows ?
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> File chrome/common/extensions/docs/templates/intros/commands.html (right):
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> chrome/common/extensions/docs/templates/intros/commands.html:15: <td>On target
> to be stable in Chrome 25</td>
> On target seems confusing .. shall we say devchannel and update it to stable
> once it hits stable ?
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> File chrome/common/extensions/docs/templates/intros/socket.html (right):
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> chrome/common/extensions/docs/templates/intros/socket.html:14: <td>On target
to
> be stable in Chrome 24</td>
> Can we change this to devchannel and update to stable when M24 is stable
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> chrome/common/extensions/docs/templates/intros/socket.html:18:
> <td><code>"socket": ["rule1", "rule2"]</code><br>
> rule1, rule2 are confusing and may be mistaken for those strings literally.
can
> we have examples here ?
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> File chrome/common/extensions/docs/templates/intros/tts.html (right):
> 
>
https://chromiumcodereview.appspot.com/11635032/diff/9001/chrome/common/exten...
> chrome/common/extensions/docs/templates/intros/tts.html:12: module, which
allows
> an extension to implement a speech engine.</td>
> extenstion or an app ?

Powered by Google App Engine
This is Rietveld 408576698