Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1163303003: PlzNavigate: Create the speculative renderer earlier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed clamy's comments; moved RFHM::BeginNavigation call into FTN::SetNavigationRequest. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 0ca09489607151bcbed660dfeaf7b5b65bc44dde..73322deaf2cb0fb4b2c2844ca2d0d6669cc8a681 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -346,6 +346,11 @@ class CONTENT_EXPORT RenderFrameHostImpl
// PlzNavigate: this call happens on all browser-initiated navigations.
void DispatchBeforeUnload(bool for_navigation);
+ // Returns true if a call to DispatchBeforeUnload will actually send the
+ // beforeunload IPC. This will not be the case if the current renderer it not
clamy 2015/06/09 16:01:30 s/beforeunload/BeforeUnload s/renderer it/renderer
carlosk 2015/06/10 11:53:09 Done.
+ // live or this frame is not the root.
clamy 2015/06/09 16:01:30 nit: I would rephrase the whole sentence as: This
carlosk 2015/06/10 11:53:09 Done.
+ bool ShouldDispatchBeforeUnload();
+
// Set the frame's opener to null in the renderer process in response to an
// action in another renderer process.
void DisownOpener();

Powered by Google App Engine
This is Rietveld 408576698