Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1163303003: PlzNavigate: Create the speculative renderer earlier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed clamy's comments; moved RFHM::BeginNavigation call into FTN::SetNavigationRequest. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 // canceled or suspended. This is important if we later return to this 339 // canceled or suspended. This is important if we later return to this
340 // RenderFrameHost. 340 // RenderFrameHost.
341 void CancelSuspendedNavigations(); 341 void CancelSuspendedNavigations();
342 342
343 // Runs the beforeunload handler for this frame. |for_navigation| indicates 343 // Runs the beforeunload handler for this frame. |for_navigation| indicates
344 // whether this call is for the current frame during a cross-process 344 // whether this call is for the current frame during a cross-process
345 // navigation. False means we're closing the entire tab. 345 // navigation. False means we're closing the entire tab.
346 // PlzNavigate: this call happens on all browser-initiated navigations. 346 // PlzNavigate: this call happens on all browser-initiated navigations.
347 void DispatchBeforeUnload(bool for_navigation); 347 void DispatchBeforeUnload(bool for_navigation);
348 348
349 // Returns true if a call to DispatchBeforeUnload will actually send the
350 // beforeunload IPC. This will not be the case if the current renderer it not
clamy 2015/06/09 16:01:30 s/beforeunload/BeforeUnload s/renderer it/renderer
carlosk 2015/06/10 11:53:09 Done.
351 // live or this frame is not the root.
clamy 2015/06/09 16:01:30 nit: I would rephrase the whole sentence as: This
carlosk 2015/06/10 11:53:09 Done.
352 bool ShouldDispatchBeforeUnload();
353
349 // Set the frame's opener to null in the renderer process in response to an 354 // Set the frame's opener to null in the renderer process in response to an
350 // action in another renderer process. 355 // action in another renderer process.
351 void DisownOpener(); 356 void DisownOpener();
352 357
353 // Deletes the current selection plus the specified number of characters 358 // Deletes the current selection plus the specified number of characters
354 // before and after the selection or caret. 359 // before and after the selection or caret.
355 void ExtendSelectionAndDelete(size_t before, size_t after); 360 void ExtendSelectionAndDelete(size_t before, size_t after);
356 361
357 // Notifies the RenderFrame that the JavaScript message that was shown was 362 // Notifies the RenderFrame that the JavaScript message that was shown was
358 // closed by the user. 363 // closed by the user.
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 731
727 // NOTE: This must be the last member. 732 // NOTE: This must be the last member.
728 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 733 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
729 734
730 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 735 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
731 }; 736 };
732 737
733 } // namespace content 738 } // namespace content
734 739
735 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 740 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698