Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.h

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make dtor protected Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/extensions_guest_view_container.h
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.h b/extensions/renderer/guest_view/extensions_guest_view_container.h
index 4e3f3e9e5ec4c25f689afec81610b60f7bf4c7c7..f80da9148697596f5ee4ae48c259630f7079175e 100644
--- a/extensions/renderer/guest_view/extensions_guest_view_container.h
+++ b/extensions/renderer/guest_view/extensions_guest_view_container.h
@@ -19,7 +19,6 @@ namespace extensions {
class ExtensionsGuestViewContainer : public guest_view::GuestViewContainer {
public:
explicit ExtensionsGuestViewContainer(content::RenderFrame* render_frame);
- ~ExtensionsGuestViewContainer() override;
void RegisterDestructionCallback(v8::Local<v8::Function> callback,
v8::Isolate* isolate);
@@ -29,9 +28,14 @@ class ExtensionsGuestViewContainer : public guest_view::GuestViewContainer {
// BrowserPluginDelegate implementation.
void DidResizeElement(const gfx::Size& new_size) override;
+ protected:
+ ~ExtensionsGuestViewContainer() override;
+
private:
void CallElementResizeCallback(const gfx::Size& new_size);
+ void OnDestroy() override;
Fady Samuel 2015/06/05 17:31:13 What is this overriding. Please specify.
lazyboy 2015/06/05 21:24:00 Done.
+
v8::Global<v8::Function> destruction_callback_;
v8::Isolate* destruction_isolate_;

Powered by Google App Engine
This is Rietveld 408576698