Move BrowserPluginDelegate's lifetime mgmt out of content/

extensions/renderer/guest_view/extensions_guest_view_container.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_
 #define EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_
 
 #include <queue>
 
 #include "components/guest_view/renderer/guest_view_container.h"
 #include "v8/include/v8.h"
 
 namespace gfx {
 class Size;
 }
 
 namespace extensions {
 
 class ExtensionsGuestViewContainer : public guest_view::GuestViewContainer {
  public:
   explicit ExtensionsGuestViewContainer(content::RenderFrame* render_frame);
-  ~ExtensionsGuestViewContainer() override;
 
   void RegisterDestructionCallback(v8::Local<v8::Function> callback,
                                    v8::Isolate* isolate);
   void RegisterElementResizeCallback(v8::Local<v8::Function> callback,
                                      v8::Isolate* isolate);
 
   // BrowserPluginDelegate implementation.
   void DidResizeElement(const gfx::Size& new_size) override;
 
+ protected:
+  ~ExtensionsGuestViewContainer() override;
+
  private:
   void CallElementResizeCallback(const gfx::Size& new_size);
 
+  void OnDestroy() override;

[Fady Samuel, 2015/06/05 17:31:13]

What is this overriding. Please specify.

[lazyboy, 2015/06/05 21:24:00]

Done.

+
   v8::Global<v8::Function> destruction_callback_;
   v8::Isolate* destruction_isolate_;
 
   v8::Global<v8::Function> element_resize_callback_;
   v8::Isolate* element_resize_isolate_;
 
   // Weak pointer factory used for calling the element resize callback.
   base::WeakPtrFactory<ExtensionsGuestViewContainer> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionsGuestViewContainer);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_