Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager.h

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make dtor protected Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_manager.h
diff --git a/content/renderer/browser_plugin/browser_plugin_manager.h b/content/renderer/browser_plugin/browser_plugin_manager.h
index 34386656ef0da03c6ad104e542824651d0e45007..6e6b2b3b77275ccaefd33afb49d91a935336e70e 100644
--- a/content/renderer/browser_plugin/browser_plugin_manager.h
+++ b/content/renderer/browser_plugin/browser_plugin_manager.h
@@ -10,6 +10,8 @@
#include "content/public/renderer/render_process_observer.h"
#include "ipc/ipc_sender.h"
+class GURL;
+
namespace blink {
class WebFrame;
}
@@ -34,9 +36,9 @@ class CONTENT_EXPORT BrowserPluginManager : public RenderProcessObserver {
// BrowserPlugin is responsible for associating itself with the
// BrowserPluginManager via AddBrowserPlugin. When it is destroyed, it is
// responsible for removing its association via RemoveBrowserPlugin.
- BrowserPlugin* CreateBrowserPlugin(
- RenderFrame* render_frame,
- scoped_ptr<BrowserPluginDelegate> delegate);
+ BrowserPlugin* CreateBrowserPlugin(RenderFrame* render_frame,
+ const std::string& mime_type,
+ const GURL& original_url);
void Attach(int browser_plugin_instance_id);

Powered by Google App Engine
This is Rietveld 408576698