content/renderer/browser_plugin/browser_plugin_manager.cc - Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager.cc

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make dtor protected Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/browser_plugin/browser_plugin.cc ('K') | « content/renderer/browser_plugin/browser_plugin_manager.h ('k') | content/renderer/render_frame_impl.cc » ('j') | extensions/renderer/guest_view/extensions_guest_view_container.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin_manager.cc

diff --git a/content/renderer/browser_plugin/browser_plugin_manager.cc b/content/renderer/browser_plugin/browser_plugin_manager.cc

index 186d6bf6cf80910367436710caa34ea0068d12b6..cf5928ab418679c0058978d76eec05631083ed87 100644

--- a/content/renderer/browser_plugin/browser_plugin_manager.cc

+++ b/content/renderer/browser_plugin/browser_plugin_manager.cc

@@ -68,8 +68,9 @@ void BrowserPluginManager::Detach(int browser_plugin_instance_id) {

BrowserPlugin* BrowserPluginManager::CreateBrowserPlugin(

RenderFrame* render_frame,

- scoped_ptr<BrowserPluginDelegate> delegate) {

- return new BrowserPlugin(render_frame, delegate.Pass());

+ const std::string& mime_type,

+ const GURL& original_url) {

+ return new BrowserPlugin(render_frame, mime_type, original_url);

}

void BrowserPluginManager::DidCommitCompositorFrame(