Removing the JumpRelative, Call, CallRelative and Return commands.

Removing the JumpRelative, Call, CallRelative and Return commands.

This removes the extra commands from the command buffer. I've left the
Jump struct and handler in place as it's used to advance the buffer
if there isn't enough room at the end to place the next command.

TESTING=Ran the gpu_unittests and everything worked correctly.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175158

[dsinclair, 2012-12-18 16:12:45]

Saw the TODO on the bottom of the GPU Command Buffer wiki page and thought I
could knock some of it off.

[greggman, 2012-12-19 03:32:18]

one minor comment then ltgm

https://codereview.chromium.org/11613021/diff/1/gpu/command_buffer/client/cmd...
File gpu/command_buffer/client/cmd_buffer_helper.h (left):

https://codereview.chromium.org/11613021/diff/1/gpu/command_buffer/client/cmd...
gpu/command_buffer/client/cmd_buffer_helper.h:152: void Jump(uint32 offset) {
Isn't Jump still needed? You seem to be keeping Jump everywhere else.

[dsinclair, 2012-12-19 03:41:07]

https://codereview.chromium.org/11613021/diff/1/gpu/command_buffer/client/cmd...
File gpu/command_buffer/client/cmd_buffer_helper.h (left):

https://codereview.chromium.org/11613021/diff/1/gpu/command_buffer/client/cmd...
gpu/command_buffer/client/cmd_buffer_helper.h:152: void Jump(uint32 offset) {
On 2012/12/19 03:32:18, greggman wrote:
> Isn't Jump still needed? You seem to be keeping Jump everywhere else.

The code that uses Jump in cmd_buffer_helper.cc uses cmd::Jump::Set directly. It
doesn't use the Jump method for some reason. I figured taking the method out was
safe (everything is compiling and most of the try-bots are happy), and removes
the client side API if not the struct and service side handling.

[dsinclair, 2013-01-03 19:13:48]

@greggman PTAL

[greggman, 2013-01-03 19:22:01]

If you want to get rid of jump you can remove the jump reference in
cmd_buffer_helper.cc. Instead insert a Noop with a size the covers the rest of
the command buffer. That's what the code used to do before we added Jump

https://codereview.chromium.org/2509001/diff/1/gpu/command_buffer/client/cmd_...

You already have LGTM so if you want to check this in as is and then add a TODO
to completely remove Jump that's fine too.

[dsinclair, 2013-01-03 21:16:04]

On 2013/01/03 19:22:01, greggman wrote:
> If you want to get rid of jump you can remove the jump reference in
> cmd_buffer_helper.cc. Instead insert a Noop with a size the covers the rest of
> the command buffer. That's what the code used to do before we added Jump
> 
>
https://codereview.chromium.org/2509001/diff/1/gpu/command_buffer/client/cmd_...
> 
> You already have LGTM so if you want to check this in as is and then add a
TODO
> to completely remove Jump that's fine too.


Thanks for the pointer. I've gone ahead and removed the Jump code completely in
this CL. Can you take one last quick look while this runs through the try bots?

Thanks,
dan

[greggman, 2013-01-03 22:32:38]

lgtm

[commit-bot: I haz the power, 2013-01-04 16:48:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/11613021/12001

[commit-bot: I haz the power, 2013-01-04 18:37:49]

Change committed as 175158