Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: gpu/command_buffer/client/ring_buffer_test.cc

Issue 11613021: Removing the JumpRelative, Call, CallRelative and Return commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use Noops instead of Jump; Remove Jump command. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/cmd_buffer_helper_test.cc ('k') | gpu/command_buffer/common/cmd_buffer_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/ring_buffer_test.cc
diff --git a/gpu/command_buffer/client/ring_buffer_test.cc b/gpu/command_buffer/client/ring_buffer_test.cc
index 55f4c0ede5476be5166a5ee29be8b74bcf78f2d4..4633e795779e12b6e7c7c4c77b0693f24ef805a7 100644
--- a/gpu/command_buffer/client/ring_buffer_test.cc
+++ b/gpu/command_buffer/client/ring_buffer_test.cc
@@ -35,25 +35,6 @@ class BaseRingBufferTest : public testing::Test {
static const unsigned int kBaseOffset = 128;
static const unsigned int kBufferSize = 1024;
- class DoJumpCommand {
- public:
- explicit DoJumpCommand(GpuScheduler* gpu_scheduler)
- : gpu_scheduler_(gpu_scheduler) {
- }
-
- error::Error DoCommand(
- unsigned int command,
- unsigned int arg_count,
- const void* cmd_data) {
- const cmd::Jump* jump_cmd = static_cast<const cmd::Jump*>(cmd_data);
- gpu_scheduler_->parser()->set_get(jump_cmd->offset);
- return error::kNoError;
- };
-
- private:
- GpuScheduler* gpu_scheduler_;
- };
-
virtual void SetUp() {
api_mock_.reset(new AsyncAPIMock);
// ignore noops in the mock - we don't want to inspect the internals of the
@@ -82,10 +63,6 @@ class BaseRingBufferTest : public testing::Test {
&GpuScheduler::SetGetBuffer, base::Unretained(gpu_scheduler_.get())));
api_mock_->set_engine(gpu_scheduler_.get());
- do_jump_command_.reset(new DoJumpCommand(gpu_scheduler_.get()));
- EXPECT_CALL(*api_mock_, DoCommand(cmd::kJump, _, _))
- .WillRepeatedly(
- Invoke(do_jump_command_.get(), &DoJumpCommand::DoCommand));
helper_.reset(new CommandBufferHelper(command_buffer_.get()));
helper_->Initialize(kBufferSize);
@@ -104,7 +81,6 @@ class BaseRingBufferTest : public testing::Test {
scoped_ptr<CommandBufferService> command_buffer_;
scoped_ptr<GpuScheduler> gpu_scheduler_;
scoped_ptr<CommandBufferHelper> helper_;
- scoped_ptr<DoJumpCommand> do_jump_command_;
};
#ifndef _MSC_VER
« no previous file with comments | « gpu/command_buffer/client/cmd_buffer_helper_test.cc ('k') | gpu/command_buffer/common/cmd_buffer_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698