Move ScriptBadge, ActionInfo out of Extension; preparation for BrowserAction

chrome/common/extensions/manifest_handler.h

Index: chrome/common/extensions/manifest_handler.h
diff --git a/chrome/common/extensions/manifest_handler.h b/chrome/common/extensions/manifest_handler.h
index 89e65093880121cca7f4e5cc15f078d2e7db9669..87530f27e5f9fddd3f7fe018b0bbca766a20d7c5 100644
--- a/chrome/common/extensions/manifest_handler.h
+++ b/chrome/common/extensions/manifest_handler.h
@@ -30,6 +30,12 @@ class ManifestHandler {
                      Extension* extension,
                      string16* error) = 0;
 
+  // Perform any initialization which is necessary even if the Handler's key is

[Yoyo Zhou, 2012/12/19 01:38:50]

"even if" makes it sound like this also happens when the key is present. Change
this to: "Perform any necessary initialization when the..."

[Devlin, 2012/12/19 19:38:17]

Done.

+  // not present in the manifest.
+  // Returns true on success or false on failure; if false, |error| will
+  // be set to a failure message.
+  virtual bool HasNoKey(Extension* extension, string16* error) { return true; }

[Yoyo Zhou, 2012/12/19 01:38:50]

nit: this would be more readable with newlines.

[Devlin, 2012/12/19 19:38:17]

Done.

+
   // Associate |handler| with |key| in the manifest. Takes ownership
   // of |handler|. TODO(yoz): Decide how to handle dotted subkeys.
   // WARNING: Manifest handlers registered only in the browser process