Move ScriptBadge, ActionInfo out of Extension; preparation for BrowserAction

chrome/common/extensions/manifest_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_H_
 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 12 matching lines @@
   ManifestHandler();
   virtual ~ManifestHandler();
 
   // Attempts to parse the manifest value.
   // Returns true on success or false on failure; if false, |error| will
   // be set to a failure message.
   virtual bool Parse(const base::Value* value,
                      Extension* extension,
                      string16* error) = 0;
 
+  // Perform any initialization which is necessary even if the Handler's key is

[Yoyo Zhou, 2012/12/19 01:38:50]

"even if" makes it sound like this also happens when the key is present. Change
this to: "Perform any necessary initialization when the..."

[Devlin, 2012/12/19 19:38:17]

Done.

+  // not present in the manifest.
+  // Returns true on success or false on failure; if false, |error| will
+  // be set to a failure message.
+  virtual bool HasNoKey(Extension* extension, string16* error) { return true; }

[Yoyo Zhou, 2012/12/19 01:38:50]

nit: this would be more readable with newlines.

[Devlin, 2012/12/19 19:38:17]

Done.

+
   // Associate |handler| with |key| in the manifest. Takes ownership
   // of |handler|. TODO(yoz): Decide how to handle dotted subkeys.
   // WARNING: Manifest handlers registered only in the browser process
   // are not available to renderers.
   static void Register(const std::string& key, ManifestHandler* handler);
 
   // Get the manifest handler associated with |key|, or NULL
   // if there is none.
   static ManifestHandler* Get(const std::string& key);
 
   // If the handler is not handling most of the keys, it may be
   // more efficient to have a list of keys to iterate over.
   // TODO(yoz): this isn't the long-term solution.
   static std::vector<std::string> GetKeys();
 };
 
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_H_