Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 11576008: Fixing identifier for device returning a 0 identifierForVendor. (Closed)

Created:
8 years ago by qsr
Modified:
8 years ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Fixing identifier for device returning a 0 identifierForVendor. R=stuartmorgan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172888

Patch Set 1 #

Patch Set 2 : Fix test. #

Patch Set 3 : Checking device id. #

Patch Set 4 : Finding out the prb #

Patch Set 5 : Fix for buggy simulator. #

Patch Set 6 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -11 lines) Patch
M base/ios/device_util.mm View 2 chunks +26 lines, -5 lines 0 comments Download
M base/ios/device_util_unittest.mm View 1 2 3 4 5 3 chunks +54 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
8 years ago (2012-12-13 12:17:26 UTC) #1
stuartmorgan
LGTM
8 years ago (2012-12-13 12:21:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/11576008/1
8 years ago (2012-12-13 12:21:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/11576008/6005
8 years ago (2012-12-13 13:21:12 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-13 17:40:02 UTC) #5
Message was sent while issue was closed.
Change committed as 172888

Powered by Google App Engine
This is Rietveld 408576698