Issue 11575027: Remove SafeBrowsingProtocolManagerTest.EmptyDatabase test.

Issue 11575027: Remove SafeBrowsingProtocolManagerTest.EmptyDatabase test. (Closed)

Created:
8 years ago by cbentzel

Modified:
8 years ago

Reviewers:
mattm

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove SafeBrowsingProtocolManagerTest.EmptyDatabase test. This code path will be re-activated in https://codereview.chromium.org/11419041, but landing this separately simplifies the diff on that CL. BUG=158245 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173647

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -26 lines)			Patch
	M	chrome/browser/safe_browsing/protocol_manager_unittest.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

mattm

Lgtm On Dec 14, 2012 3:45 AM, <cbentzel@chromium.org> wrote: > Reviewers: mattm, > > Message: ...

8 years ago (2012-12-14 17:39:42 UTC) #2

Lgtm
On Dec 14, 2012 3:45 AM, <cbentzel@chromium.org> wrote:

> Reviewers: mattm,
>
> Message:
> Simply removes a test to make other diffs cleaner.
>
> Description:
> Remove SafeBrowsingProtocolManagerTes**t.EmptyDatabase test.
>
> This code path will be re-activated in https://codereview.chromium.**
> org/11419041 <https://codereview.chromium.org/11419041>,
> but landing this separately simplifies the diff on that CL.
>
> BUG=158245
>
>
> Please review this at
https://codereview.chromium.**org/11575027/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/safe_browsing/**protocol_manager_unittest.cc
>
>
> Index: chrome/browser/safe_browsing/**protocol_manager_unittest.cc
> diff --git a/chrome/browser/safe_**browsing/protocol_manager_**unittest.cc
> b/chrome/browser/safe_**browsing/protocol_manager_**unittest.cc
> index 75f4097b89681bcfa7b62eedd9b55a**bfabcb2637..**
> aad096da455b925aff9af0869fc486**217baf5a31 100644
> --- a/chrome/browser/safe_**browsing/protocol_manager_**unittest.cc
> +++ b/chrome/browser/safe_**browsing/protocol_manager_**unittest.cc
> @@ -336,32 +336,6 @@ TEST_F(**SafeBrowsingProtocolManagerTes**t,
> ProblemAccessingDatabase) {
>    runner->RunTasks();
>  }
>
> -// Tests the contents of the POST body when the local database is empty.
> -TEST_F(**SafeBrowsingProtocolManagerTes**t, EmptyDatabase) {
> -  scoped_refptr<**ImmediateSingleThreadTaskRunne**r> runner(
> -      new ImmediateSingleThreadTaskRunne**r());
> -  base::ThreadTaskRunnerHandle runner_handler(runner);
> -  net::TestURLFetcherFactory url_fetcher_factory;
> -
> -  testing::StrictMock<**MockProtocolDelegate> test_delegate;
> -  EXPECT_CALL(test_delegate, UpdateStarted()).Times(1);
> -  EXPECT_CALL(test_delegate, GetChunks(_)).WillOnce(
> -      Invoke(testing::CreateFunctor(**InvokeGetChunksCallback,
> -                                    std::vector<SBListChunkRanges>**(),
> -                                    false)));
> -
> -  scoped_ptr<**SafeBrowsingProtocolManager> pm(
> -      CreateProtocolManager(&test_**delegate));
> -
> -  // Kick off initialization. This returns chunks from the DB
> synchronously.
> -  pm->ForceScheduleNextUpdate(**base::TimeDelta());
> -  runner->RunTasks();
> -
> -  // We should have an URLFetcher at this point in time.
> -  net::TestURLFetcher* url_fetcher = url_fetcher_factory.**
> GetFetcherByID(0);
> -  ValidateUpdateFetcherRequest(**url_fetcher);
> -}
> -
>  // Tests the contents of the POST body when there are contents in the
>  // local database. This is not exhaustive, as the actual list formatting
>  // is covered by SafeBrowsingProtocolManagerTes**t.TestChunkStrings.
>
>
>