Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3355)

Unified Diff: chrome/browser/safe_browsing/protocol_manager_unittest.cc

Issue 11575027: Remove SafeBrowsingProtocolManagerTest.EmptyDatabase test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/protocol_manager_unittest.cc
diff --git a/chrome/browser/safe_browsing/protocol_manager_unittest.cc b/chrome/browser/safe_browsing/protocol_manager_unittest.cc
index 75f4097b89681bcfa7b62eedd9b55abfabcb2637..aad096da455b925aff9af0869fc486217baf5a31 100644
--- a/chrome/browser/safe_browsing/protocol_manager_unittest.cc
+++ b/chrome/browser/safe_browsing/protocol_manager_unittest.cc
@@ -336,32 +336,6 @@ TEST_F(SafeBrowsingProtocolManagerTest, ProblemAccessingDatabase) {
runner->RunTasks();
}
-// Tests the contents of the POST body when the local database is empty.
-TEST_F(SafeBrowsingProtocolManagerTest, EmptyDatabase) {
- scoped_refptr<ImmediateSingleThreadTaskRunner> runner(
- new ImmediateSingleThreadTaskRunner());
- base::ThreadTaskRunnerHandle runner_handler(runner);
- net::TestURLFetcherFactory url_fetcher_factory;
-
- testing::StrictMock<MockProtocolDelegate> test_delegate;
- EXPECT_CALL(test_delegate, UpdateStarted()).Times(1);
- EXPECT_CALL(test_delegate, GetChunks(_)).WillOnce(
- Invoke(testing::CreateFunctor(InvokeGetChunksCallback,
- std::vector<SBListChunkRanges>(),
- false)));
-
- scoped_ptr<SafeBrowsingProtocolManager> pm(
- CreateProtocolManager(&test_delegate));
-
- // Kick off initialization. This returns chunks from the DB synchronously.
- pm->ForceScheduleNextUpdate(base::TimeDelta());
- runner->RunTasks();
-
- // We should have an URLFetcher at this point in time.
- net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
- ValidateUpdateFetcherRequest(url_fetcher);
-}
-
// Tests the contents of the POST body when there are contents in the
// local database. This is not exhaustive, as the actual list formatting
// is covered by SafeBrowsingProtocolManagerTest.TestChunkStrings.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698