[content shell] implement testRunner.execCommand

content/shell/webkit_test_runner_bindings.cc

Index: content/shell/webkit_test_runner_bindings.cc
diff --git a/content/shell/webkit_test_runner_bindings.cc b/content/shell/webkit_test_runner_bindings.cc
index 48c37ea1f59bc8883d248cf53a058e6bf6eab5d6..b31c1d0cd56feefd7abfabf75a22bd866903ab9c 100644
--- a/content/shell/webkit_test_runner_bindings.cc
+++ b/content/shell/webkit_test_runner_bindings.cc
@@ -158,6 +158,27 @@ v8::Handle<v8::Value> EvaluateInWebInspector(const v8::Arguments& args) {
   return v8::Undefined();
 }
 
+v8::Handle<v8::Value> ExecCommand(const v8::Arguments& args) {
+  if (args.Length() == 0 || args.Length() > 3)
+    return v8::Undefined();
+
+  if (!args[0]->IsString() || (args.Length() == 3 && !args[2]->IsString()))

[marja, 2012/12/14 12:47:44]

Hmm? What and what types are the args expected to be (depending on args.Length()
somehow)?

[jochen (gone - plz use gerrit), 2012/12/14 12:56:21]

It can have 1 - 3 parameters, but I only care about the first and the last, both
need to be strings.

The first check is 0 or more then three parameters -> fail

the second is if the first is not a string or we have three parameters and the
third is not a string -> fail

makes sense?

+    return v8::Undefined();
+
+  WebKitTestRunner* runner =
+      ShellRenderProcessObserver::GetInstance()->main_test_runner();
+  if (!runner)
+    return v8::Undefined();
+
+  std::string command(*v8::String::AsciiValue(args[0]));
+  std::string value;
+  if (args.Length() == 3)
+    value = *v8::String::AsciiValue(args[2]);
+
+  runner->ExecCommand(command, value);
+  return v8::Undefined();
+}
+
 v8::Handle<v8::Value> GetGlobalFlag(const v8::Arguments& args) {
   return v8::Boolean::New(g_global_flag);
 }
@@ -237,6 +258,8 @@ WebKitTestRunnerBindings::GetNativeFunction(v8::Handle<v8::String> name) {
     return v8::FunctionTemplate::New(CloseWebInspector);
   if (name->Equals(v8::String::New("EvaluateInWebInspector")))
     return v8::FunctionTemplate::New(EvaluateInWebInspector);
+  if (name->Equals(v8::String::New("ExecCommand")))
+    return v8::FunctionTemplate::New(ExecCommand);
   if (name->Equals(v8::String::New("GetGlobalFlag")))
     return v8::FunctionTemplate::New(GetGlobalFlag);
   if (name->Equals(v8::String::New("SetGlobalFlag")))