[content shell] implement testRunner.execCommand

content/shell/webkit_test_runner_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/webkit_test_runner_bindings.h"
 
 #include "base/logging.h"
 #include "base/string_piece.h"
 #include "content/public/renderer/render_view.h"
 #include "content/shell/shell_render_process_observer.h"
@@ skipping 140 matching lines @@
   WebKitTestRunner* runner =
       ShellRenderProcessObserver::GetInstance()->main_test_runner();
   if (!runner)
     return v8::Undefined();
 
   runner->EvaluateInWebInspector(args[0]->Int32Value(),
                                  *v8::String::AsciiValue(args[1]));
   return v8::Undefined();
 }
 
+v8::Handle<v8::Value> ExecCommand(const v8::Arguments& args) {
+  if (args.Length() == 0 || args.Length() > 3)
+    return v8::Undefined();
+
+  if (!args[0]->IsString() || (args.Length() == 3 && !args[2]->IsString()))

[marja, 2012/12/14 12:47:44]

Hmm? What and what types are the args expected to be (depending on args.Length()
somehow)?

[jochen (gone - plz use gerrit), 2012/12/14 12:56:21]

It can have 1 - 3 parameters, but I only care about the first and the last, both
need to be strings.

The first check is 0 or more then three parameters -> fail

the second is if the first is not a string or we have three parameters and the
third is not a string -> fail

makes sense?

+    return v8::Undefined();
+
+  WebKitTestRunner* runner =
+      ShellRenderProcessObserver::GetInstance()->main_test_runner();
+  if (!runner)
+    return v8::Undefined();
+
+  std::string command(*v8::String::AsciiValue(args[0]));
+  std::string value;
+  if (args.Length() == 3)
+    value = *v8::String::AsciiValue(args[2]);
+
+  runner->ExecCommand(command, value);
+  return v8::Undefined();
+}
+
 v8::Handle<v8::Value> GetGlobalFlag(const v8::Arguments& args) {
   return v8::Boolean::New(g_global_flag);
 }
 
 v8::Handle<v8::Value> SetGlobalFlag(const v8::Arguments& args) {
   if (args.Length() == 1 && args[0]->IsBoolean())
     g_global_flag = args[0]->BooleanValue();
   return v8::Undefined();
 }
 
@@ skipping 59 matching lines @@
   if (name->Equals(v8::String::New("SetXSSAuditorEnabled")))
     return v8::FunctionTemplate::New(SetXSSAuditorEnabled);
   if (name->Equals(v8::String::New("GetWorkerThreadCount")))
     return v8::FunctionTemplate::New(GetWorkerThreadCount);
   if (name->Equals(v8::String::New("ShowWebInspector")))
     return v8::FunctionTemplate::New(ShowWebInspector);
   if (name->Equals(v8::String::New("CloseWebInspector")))
     return v8::FunctionTemplate::New(CloseWebInspector);
   if (name->Equals(v8::String::New("EvaluateInWebInspector")))
     return v8::FunctionTemplate::New(EvaluateInWebInspector);
+  if (name->Equals(v8::String::New("ExecCommand")))
+    return v8::FunctionTemplate::New(ExecCommand);
   if (name->Equals(v8::String::New("GetGlobalFlag")))
     return v8::FunctionTemplate::New(GetGlobalFlag);
   if (name->Equals(v8::String::New("SetGlobalFlag")))
     return v8::FunctionTemplate::New(SetGlobalFlag);
   if (name->Equals(v8::String::New("NotImplemented")))
     return v8::FunctionTemplate::New(NotImplemented);
 
   NOTREACHED();
   return v8::FunctionTemplate::New();
 }
 
 }  // namespace content