[content shell] implement testRunner.execCommand

[content shell] implement testRunner.execCommand

BUG=111316
TEST=editing/execCommand tests pass
R=marja@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173210

[marja, 2012-12-14 12:47:44]

chemistry-dog lgtm, but...

https://chromiumcodereview.appspot.com/11573035/diff/1/content/shell/webkit_t...
File content/shell/webkit_test_runner_bindings.cc (right):

https://chromiumcodereview.appspot.com/11573035/diff/1/content/shell/webkit_t...
content/shell/webkit_test_runner_bindings.cc:165: if (!args[0]->IsString() ||
(args.Length() == 3 && !args[2]->IsString()))
Hmm? What and what types are the args expected to be (depending on args.Length()
somehow)?

[jochen (gone - plz use gerrit), 2012-12-14 12:56:21]

https://chromiumcodereview.appspot.com/11573035/diff/1/content/shell/webkit_t...
File content/shell/webkit_test_runner_bindings.cc (right):

https://chromiumcodereview.appspot.com/11573035/diff/1/content/shell/webkit_t...
content/shell/webkit_test_runner_bindings.cc:165: if (!args[0]->IsString() ||
(args.Length() == 3 && !args[2]->IsString()))
On 2012/12/14 12:47:44, marja wrote:
> Hmm? What and what types are the args expected to be (depending on
args.Length()
> somehow)?

It can have 1 - 3 parameters, but I only care about the first and the last, both
need to be strings.

The first check is 0 or more then three parameters -> fail

the second is if the first is not a string or we have three parameters and the
third is not a string -> fail

makes sense?

[commit-bot: I haz the power, 2012-12-14 13:01:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/11573035/5001

[commit-bot: I haz the power, 2012-12-14 18:22:57]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-14 21:14:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/11573035/5001

[commit-bot: I haz the power, 2012-12-14 21:17:11]

Change committed as 173210