Issue 11573034: Add DEPS rules to help enforce the general rule that the embedder should provide URLs and access to…

Issue 11573034: Add DEPS rules to help enforce the general rule that the embedder should provide URLs and access to… (Closed)

Created:
8 years ago by Jói

Modified:
8 years ago

Reviewers:
joth, jabdelmalek

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add DEPS rules to help enforce the general rule that the embedder should provide URLs and access tokens to server-side services. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173538

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add missing file. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
M	content/DEPS	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
A	content/browser/geolocation/DEPS	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/speech/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

joth

thanks! https://codereview.chromium.org/11573034/diff/1/content/DEPS File content/DEPS (right): https://codereview.chromium.org/11573034/diff/1/content/DEPS#newcode38 content/DEPS:38: # content/browser/geolocation/DEPS. Both of these are cases of ...

8 years ago (2012-12-14 23:53:39 UTC) #2

Jói

Thanks, added the missing file. Please LGTM if good now. On Fri, Dec 14, 2012 ...

8 years ago (2012-12-17 14:30:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/11573034/5001

8 years ago (2012-12-17 18:07:34 UTC) #5

commit-bot: I haz the power

Presubmit check for 11573034-5001 failed and returned exit status 1. Running presubmit commit checks ...

8 years ago (2012-12-17 18:07:38 UTC) #6

Jói

John, looks like I need your stamp of approval before committing. Cheers, Jói

8 years ago (2012-12-17 18:08:04 UTC) #7

jam

lgtm On Mon, Dec 17, 2012 at 10:08 AM, <joi@chromium.org> wrote: > John, looks like ...

8 years ago (2012-12-17 18:10:35 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/11573034/5001

8 years ago (2012-12-17 18:13:04 UTC) #9

Message was sent while issue was closed.

Change committed as 173538

Expand Messages | Collapse Messages