Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: content/DEPS

Issue 11573034: Add DEPS rules to help enforce the general rule that the embedder should provide URLs and access to… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add missing file. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/geolocation/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/DEPS
diff --git a/content/DEPS b/content/DEPS
index 0362df1fd7aeed26767f30f43dc24b29265188cd..e615c72f295a829345287267703386343fd6c915 100644
--- a/content/DEPS
+++ b/content/DEPS
@@ -15,8 +15,6 @@ include_rules = [
"+content/shell", # for content_browsertests
"+content/test",
- "+google_apis",
-
"+grit/content_resources.h",
"+grit/ui_resources.h",
"+grit/webkit_chromium_resources.h",
@@ -31,6 +29,18 @@ include_rules = [
"+sandbox",
"+skia",
+ # In general, content/ should not rely on google_apis, since URLs
+ # and access tokens should usually be provided by the
+ # embedder.
+ #
+ # There are a couple of specific parts of content that are excepted
+ # from this rule, see content/browser/speech/DEPS and
+ # content/browser/geolocation/DEPS. Both of these are cases of
+ # implementations that are strongly tied to Google servers, i.e. we
+ # don't expect alternate implementations to be provided by the
+ # embedder.
+ "-google_apis",
+
# Don't allow inclusion of these other libs we shouldn't be calling directly.
"-v8",
"-tools",
« no previous file with comments | « no previous file | content/browser/geolocation/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698