Telemetry: More elegant histogram printing.

Telemetry: More elegant histogram printing.

We now consider the _by_url data important for histograms, and only print out
histograms one by one. So we don't need hacks in perf_tests_helper for printing
out a list of histograms (for which we don't any more know which page they refer to).

BUG=158323
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172939

[marja, 2012-12-13 15:18:22]

tonyg@, bulach@: ptal.

Ironically, this partially undoes my histogram printing fix in
https://codereview.chromium.org/11413144 ; but now we really have only one
histogram to print out.

[bulach, 2012-12-13 18:21:59]

thanks marja! I'm not too familiar here, so just some drive-by comments and I'll
leave this to tony..

https://chromiumcodereview.appspot.com/11573008/diff/1/build/android/pylib/pe...
File build/android/pylib/perf_tests_helper.py (right):

https://chromiumcodereview.appspot.com/11573008/diff/1/build/android/pylib/pe...
build/android/pylib/perf_tests_helper.py:107: # average information from them.
sorry, not sure I follow :) isn't 116 computing avg?
perhaps it'd be clearer as something like:
# The histograms can only be printed individually, there's
# no computation across different histograms.

(but then again, I may have completely misunderstood this..)

https://chromiumcodereview.appspot.com/11573008/diff/1/build/android/pylib/pe...
build/android/pylib/perf_tests_helper.py:110: measurement = measurement + '.' +
trace_name
nit: measurement += '.' + trace_name

[marja, 2012-12-13 18:31:42]

Thanks for comments!

https://chromiumcodereview.appspot.com/11573008/diff/1/build/android/pylib/pe...
File build/android/pylib/perf_tests_helper.py (right):

https://chromiumcodereview.appspot.com/11573008/diff/1/build/android/pylib/pe...
build/android/pylib/perf_tests_helper.py:107: # average information from them.
On 2012/12/13 18:21:59, bulach wrote:
> sorry, not sure I follow :) isn't 116 computing avg?
> perhaps it'd be clearer as something like:
> # The histograms can only be printed individually, there's
> # no computation across different histograms.
> 
> (but then again, I may have completely misunderstood this..)

Your comment was what I meant exactly. So we don't compute anything from a list
of histograms, but we compute averages from a single histogram.

-> Changed the comment to what you suggested.

https://chromiumcodereview.appspot.com/11573008/diff/1/build/android/pylib/pe...
build/android/pylib/perf_tests_helper.py:110: measurement = measurement + '.' +
trace_name
On 2012/12/13 18:21:59, bulach wrote:
> nit: measurement += '.' + trace_name

Done.

[tonyg, 2012-12-13 19:48:15]

lgtm

[commit-bot: I haz the power, 2012-12-13 19:56:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/11573008/2002

[commit-bot: I haz the power, 2012-12-13 20:00:15]

Change committed as 172939