Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: tools/telemetry/telemetry/multi_page_benchmark.py

Issue 11573008: Telemetry: More elegant histogram printing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review (bulach) Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/perf_tests_helper.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/multi_page_benchmark.py
diff --git a/tools/telemetry/telemetry/multi_page_benchmark.py b/tools/telemetry/telemetry/multi_page_benchmark.py
index 4d051dcdd85fc31a8b68bc88b3af34b5095f3730..3a8b734aeb55ee4daa15ffa158a6dd650ce3cb1c 100644
--- a/tools/telemetry/telemetry/multi_page_benchmark.py
+++ b/tools/telemetry/telemetry/multi_page_benchmark.py
@@ -81,9 +81,11 @@ results! You must return the same dict keys every time."""
self.results_summary.iteritems()):
measurement, units, data_type = measurement_units_type
if data_type == 'histogram':
- unimportant_data_type = 'unimportant-histogram'
+ # For histograms, the _by_url data is important.
+ by_url_data_type = 'histogram'
else:
- unimportant_data_type = 'unimportant'
+ # For non-histograms, the _by_url data is unimportant.
+ by_url_data_type = 'unimportant'
if '.' in measurement:
measurement, trace = measurement.split('.', 1)
trace += (trace_tag or '')
@@ -94,8 +96,10 @@ results! You must return the same dict keys every time."""
assert len(self.urls) == len(values)
for i, value in enumerate(values):
PrintPerfResult(measurement + '_by_url', self.urls[i], [value], units,
- unimportant_data_type)
- PrintPerfResult(measurement, trace, values, units, data_type)
+ by_url_data_type)
+ # For histograms, we don't print the average data, only the _by_url.
+ if not data_type == 'histogram':
+ PrintPerfResult(measurement, trace, values, units, data_type)
class IncrementalBenchmarkResults(BenchmarkResults):
« no previous file with comments | « build/android/pylib/perf_tests_helper.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698