Bump dictionary versions to 3-0

Bump dictionary versions to 3-0

Bumps the dictionary versions to 3-0 to:
1) Use the dictionaries with checksums.
2) Add dictionaries for ko, sq, and ta.
3) Update dictionaries for lv, nl, ru, and sv.

BUG=8397, 8803, 20083, 61206, 65115, 104891, 112227, 113821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175549

[please use gerrit instead, 2012-12-15 02:26:32]

Rlp: PTAL.

[rpetterson, 2012-12-15 03:53:47]

https://codereview.chromium.org/11566003/diff/7003/chrome/renderer/spellcheck...
File chrome/renderer/spellchecker/spellcheck_unittest.cc (right):

https://codereview.chromium.org/11566003/diff/7003/chrome/renderer/spellcheck...
chrome/renderer/spellchecker/spellcheck_unittest.cc:1265:
ReinitializeSpellCheck(spellcheck_languages[i]);
The only error this function will output (from what I can tell) is if there is a
bad directory. You already check to see if the file exists here. So I would add
some additional checks to this function (i.e., was the platform file created
properly) or just not call this function if there's nothing specific to check.

https://codereview.chromium.org/11566003/diff/7003/chrome/tools/convert_dict/...
File chrome/tools/convert_dict/dic_reader.cc (right):

https://codereview.chromium.org/11566003/diff/7003/chrome/tools/convert_dict/...
chrome/tools/convert_dict/dic_reader.cc:124: found->second.insert(affix_index);
I'm not sure I see how this fixes the issue where later affixes need to
overwrite affixes earlier in the same file?

[please use gerrit instead, 2012-12-15 04:19:14]

Rlp: PTAL.

https://codereview.chromium.org/11566003/diff/7003/chrome/renderer/spellcheck...
File chrome/renderer/spellchecker/spellcheck_unittest.cc (right):

https://codereview.chromium.org/11566003/diff/7003/chrome/renderer/spellcheck...
chrome/renderer/spellchecker/spellcheck_unittest.cc:1265:
ReinitializeSpellCheck(spellcheck_languages[i]);
On 2012/12/15 03:53:47, rpetterson wrote:
> The only error this function will output (from what I can tell) is if there is
a
> bad directory. You already check to see if the file exists here. So I would
add
> some additional checks to this function (i.e., was the platform file created
> properly) or just not call this function if there's nothing specific to check.

Removed.

https://codereview.chromium.org/11566003/diff/7003/chrome/tools/convert_dict/...
File chrome/tools/convert_dict/dic_reader.cc (right):

https://codereview.chromium.org/11566003/diff/7003/chrome/tools/convert_dict/...
chrome/tools/convert_dict/dic_reader.cc:124: found->second.insert(affix_index);
On 2012/12/15 03:53:47, rpetterson wrote:
> I'm not sure I see how this fixes the issue where later affixes need to
> overwrite affixes earlier in the same file?

This fixes the following case:

Word/S                   # <--- affix_index = 1
Word                     # <--- affix_index = 0

The dictionary writer here expected the final set of affixes indexes to be [1,
0]. Without this line, unit test SpellCheckTest.SpellCheckText unit test fails
for a few languages.

The case that you fixed was the following:

Word/S                   # <--- affix_index = 1
Word/!                   # <--- affix_index = 2

We need the final set of affix indexes to be [2].

[please use gerrit instead, 2012-12-15 22:00:19]

https://codereview.chromium.org/11566003/diff/7003/chrome/tools/convert_dict/...
File chrome/tools/convert_dict/dic_reader.cc (right):

https://codereview.chromium.org/11566003/diff/7003/chrome/tools/convert_dict/...
chrome/tools/convert_dict/dic_reader.cc:124: found->second.insert(affix_index);
On 2012/12/15 04:19:14, Rouslan Solomakhin wrote:
> On 2012/12/15 03:53:47, rpetterson wrote:
> > I'm not sure I see how this fixes the issue where later affixes need to
> > overwrite affixes earlier in the same file?
> 
> This fixes the following case:
> 
> Word/S                   # <--- affix_index = 1
> Word                     # <--- affix_index = 0
> 
> The dictionary writer here expected the final set of affixes indexes to be [1,
> 0]. Without this line, unit test SpellCheckTest.SpellCheckText unit test fails
> for a few languages.
> 
> The case that you fixed was the following:
> 
> Word/S                   # <--- affix_index = 1
> Word/!                   # <--- affix_index = 2
> 
> We need the final set of affix indexes to be [2].

Rlp: Let me investigate more into how convert_dict works and bdic, dic, aff file
formats.

[please use gerrit instead, 2012-12-25 01:23:03]

Rlp: PTAL.

The reason for ignoring NOSUGGEST affix was the affix ordering. Earlier affixes
that appeared in the dic file had higher priority than the later affixes added
in the dic_delta file. Some words need to have multiple affixes, however, and so
we cannot simply overwrite the existing affix when we find a new one. I went
with the solution of reversing the order of affixes, such that later affixes
have higher priority.

[rpetterson, 2012-12-26 20:22:09]

LGTM

Thanks for cleaning up the tests.

[commit-bot: I haz the power, 2013-01-07 21:34:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/11566003/26003

[commit-bot: I haz the power, 2013-01-07 21:34:51]

Presubmit check for 11566003-26003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.3s to calculate.

[please use gerrit instead, 2013-01-07 21:36:56]

Jhawkins: PTAL at chrome/common/spellcheck_common.cc

[James Hawkins, 2013-01-07 21:47:02]

lgtm

[commit-bot: I haz the power, 2013-01-07 21:52:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/11566003/26003

[commit-bot: I haz the power, 2013-01-08 16:26:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/11566003/26003

[commit-bot: I haz the power, 2013-01-08 18:04:34]

Change committed as 175549