[content shell] use WebTestRunner::WebPreferences for layout tests

[content shell] use WebTestRunner::WebPreferences for layout tests

Also, implement two further TestDelegate methods

BUG=111316
TEST=xssAuditor tests still work
R=marja@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173402

[marja, 2012-12-14 17:51:13]

lgtm, also did you mean "to" -> "two" in your CL description, or what's wrong
with the sentence..?

[commit-bot: I haz the power, 2012-12-14 21:17:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/11565036/1

[commit-bot: I haz the power, 2012-12-14 21:47:13]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-16 21:37:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/11565036/12001

[commit-bot: I haz the power, 2012-12-17 00:16:38]

Change committed as 173402

[jam, 2012-12-17 16:30:33]

https://chromiumcodereview.appspot.com/11565036/diff/12001/content/shell/shel...
File content/shell/shell_webpreferences.h (right):

https://chromiumcodereview.appspot.com/11565036/diff/12001/content/shell/shel...
content/shell/shell_webpreferences.h:16: struct ShellWebPreferences : public
WebTestRunner::WebPreferences {
just saw this when looking through your other change. so now this test runner
struct is used for content shell when not running layout tests? do we really
want that?

[jochen (gone - plz use gerrit), 2012-12-17 16:40:44]

On 2012/12/17 16:30:33, John Abd-El-Malek wrote:
>
https://chromiumcodereview.appspot.com/11565036/diff/12001/content/shell/shel...
> File content/shell/shell_webpreferences.h (right):
> 
>
https://chromiumcodereview.appspot.com/11565036/diff/12001/content/shell/shel...
> content/shell/shell_webpreferences.h:16: struct ShellWebPreferences : public
> WebTestRunner::WebPreferences {
> just saw this when looking through your other change. so now this test runner
> struct is used for content shell when not running layout tests? do we really
> want that?

The ShellWebPreferences are only used between WebKitTestRunner and
WebKitTestController, both of which are not present when not running layout
tests

[jam, 2012-12-17 17:22:59]

On 2012/12/17 16:40:44, jochen wrote:
> On 2012/12/17 16:30:33, John Abd-El-Malek wrote:
> >
>
https://chromiumcodereview.appspot.com/11565036/diff/12001/content/shell/shel...
> > File content/shell/shell_webpreferences.h (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/11565036/diff/12001/content/shell/shel...
> > content/shell/shell_webpreferences.h:16: struct ShellWebPreferences : public
> > WebTestRunner::WebPreferences {
> > just saw this when looking through your other change. so now this test
runner
> > struct is used for content shell when not running layout tests? do we really
> > want that?
> 
> The ShellWebPreferences are only used between WebKitTestRunner and
> WebKitTestController, both of which are not present when not running layout
> tests

oh, I see. should it be named differently to reflect that it's only used for
layout tests?