Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: content/shell/webkit_test_controller.h

Issue 11565036: [content shell] use WebTestRunner::WebPreferences for layout tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/webkit_test_controller.h
diff --git a/content/shell/webkit_test_controller.h b/content/shell/webkit_test_controller.h
index bf974a72354be5eafc28159bc1dc68f8b1be7cfd..54f77ddcc984ccd6cdf757c0e6095d17b852009d 100644
--- a/content/shell/webkit_test_controller.h
+++ b/content/shell/webkit_test_controller.h
@@ -10,17 +10,18 @@
#include "base/cancelable_callback.h"
#include "base/file_path.h"
+#include "base/memory/scoped_ptr.h"
#include "base/synchronization/lock.h"
#include "base/threading/non_thread_safe.h"
#include "content/public/browser/render_view_host_observer.h"
#include "content/public/browser/web_contents_observer.h"
-#include "content/shell/shell_webpreferences.h"
class SkBitmap;
namespace content {
class Shell;
+struct ShellWebPreferences;
class WebKitTestResultPrinter {
public:
@@ -86,7 +87,7 @@ class WebKitTestController : public base::NonThreadSafe,
void set_printer(WebKitTestResultPrinter* printer) {
printer_.reset(printer);
}
- const ShellWebPreferences& web_preferences() const { return prefs_; }
+ const ShellWebPreferences& web_preferences() const { return *prefs_.get(); }
bool should_stay_on_page_after_handling_before_unload() const {
return should_stay_on_page_after_handling_before_unload_;
}
@@ -145,7 +146,9 @@ class WebKitTestController : public base::NonThreadSafe,
bool is_printing_;
bool should_stay_on_page_after_handling_before_unload_;
bool wait_until_done_;
- ShellWebPreferences prefs_;
+ // TODO(jochen): Once we remove layout tests from content_browsertests, make
+ // this a member instead of a scoped_ptr.
+ scoped_ptr<ShellWebPreferences> prefs_;
base::CancelableClosure watchdog_;

Powered by Google App Engine
This is Rietveld 408576698