Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 11565033: Android pylib: measurement name escaping fix. (Closed)

Created:
8 years ago by marja
Modified:
8 years ago
Reviewers:
bulach
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, michaelbai
Visibility:
Public.

Description

Android pylib: measurement name escaping fix. The original re.sub wasn't doing at all what wanted. Also, added / to be replaced, because we now have URLs in measurement names, and measurement names are also used for constructing directory names. BUG=NONE NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173167

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/perf_tests_helper.py View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
marja
bulach: ptal michaelbai: fyi
8 years ago (2012-12-14 13:59:41 UTC) #1
bulach
lgtm https://chromiumcodereview.appspot.com/11565033/diff/1/build/android/pylib/perf_tests_helper.py File build/android/pylib/perf_tests_helper.py (right): https://chromiumcodereview.appspot.com/11565033/diff/1/build/android/pylib/perf_tests_helper.py#newcode22 build/android/pylib/perf_tests_helper.py:22: return re.sub('[\:|=/]', '_', s) nit: would this work? ...
8 years ago (2012-12-14 14:23:34 UTC) #2
marja
Thanks! https://chromiumcodereview.appspot.com/11565033/diff/1/build/android/pylib/perf_tests_helper.py File build/android/pylib/perf_tests_helper.py (right): https://chromiumcodereview.appspot.com/11565033/diff/1/build/android/pylib/perf_tests_helper.py#newcode22 build/android/pylib/perf_tests_helper.py:22: return re.sub('[\:|=/]', '_', s) On 2012/12/14 14:23:34, bulach ...
8 years ago (2012-12-14 16:17:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/11565033/1
8 years ago (2012-12-14 16:17:40 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-14 16:19:02 UTC) #5
Message was sent while issue was closed.
Change committed as 173167

Powered by Google App Engine
This is Rietveld 408576698