Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: build/android/pylib/perf_tests_helper.py

Issue 11565033: Android pylib: measurement name escaping fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/perf_tests_helper.py
diff --git a/build/android/pylib/perf_tests_helper.py b/build/android/pylib/perf_tests_helper.py
index 3334b0b3943e3b3a5de0ce07ea2c1a38edb95ca1..ca9023b679393c4c6df7e5e73d39d7c259d8a9a4 100644
--- a/build/android/pylib/perf_tests_helper.py
+++ b/build/android/pylib/perf_tests_helper.py
@@ -18,8 +18,8 @@ RESULT_TYPES = {'unimportant': 'RESULT ',
def _EscapePerfResult(s):
"""Escapes |s| for use in a perf result."""
- # Colons (:) and equal signs (=) are not allowed.
- return re.sub(':|=', '_', s)
+ # Colons (:), equal signs (=) and slashes (/) are not allowed.
+ return re.sub('[\:|=/]', '_', s)
bulach 2012/12/14 14:23:34 nit: would this work? r'[:=/]'
marja 2012/12/14 16:17:13 Yeah, but imo it's not any clearer than this versi
def GeomMeanAndStdDevFromHistogram(histogram_json):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698