Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 1155113004: Merge ApplicationSwitches.java and ChromeSwitches.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.ntp; 5 package org.chromium.chrome.browser.ntp;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.res.Resources; 9 import android.content.res.Resources;
10 import android.graphics.Bitmap; 10 import android.graphics.Bitmap;
(...skipping 20 matching lines...) Expand all
31 import android.widget.FrameLayout; 31 import android.widget.FrameLayout;
32 import android.widget.ImageView; 32 import android.widget.ImageView;
33 import android.widget.TextView; 33 import android.widget.TextView;
34 34
35 import com.google.android.apps.chrome.R; 35 import com.google.android.apps.chrome.R;
36 36
37 import org.chromium.base.CommandLine; 37 import org.chromium.base.CommandLine;
38 import org.chromium.base.FieldTrialList; 38 import org.chromium.base.FieldTrialList;
39 import org.chromium.base.VisibleForTesting; 39 import org.chromium.base.VisibleForTesting;
40 import org.chromium.base.metrics.RecordHistogram; 40 import org.chromium.base.metrics.RecordHistogram;
41 import org.chromium.chrome.browser.ApplicationSwitches; 41 import org.chromium.chrome.browser.ChromeSwitches;
42 import org.chromium.chrome.browser.LogoBridge.Logo; 42 import org.chromium.chrome.browser.LogoBridge.Logo;
43 import org.chromium.chrome.browser.LogoBridge.LogoObserver; 43 import org.chromium.chrome.browser.LogoBridge.LogoObserver;
44 import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback; 44 import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;
45 import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback; 45 import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
46 import org.chromium.chrome.browser.ntp.MostVisitedItem.MostVisitedItemManager; 46 import org.chromium.chrome.browser.ntp.MostVisitedItem.MostVisitedItemManager;
47 import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener; 47 import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener;
48 import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObse rver; 48 import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObse rver;
49 import org.chromium.chrome.browser.profiles.MostVisitedSites.ThumbnailCallback; 49 import org.chromium.chrome.browser.profiles.MostVisitedSites.ThumbnailCallback;
50 import org.chromium.chrome.browser.util.FeatureUtilities; 50 import org.chromium.chrome.browser.util.FeatureUtilities;
51 import org.chromium.chrome.browser.util.ViewUtils; 51 import org.chromium.chrome.browser.util.ViewUtils;
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 * Default constructor required for XML inflation. 203 * Default constructor required for XML inflation.
204 */ 204 */
205 public NewTabPageView(Context context, AttributeSet attrs) { 205 public NewTabPageView(Context context, AttributeSet attrs) {
206 super(context, attrs); 206 super(context, attrs);
207 } 207 }
208 208
209 private boolean isIconNtpEnabled() { 209 private boolean isIconNtpEnabled() {
210 // Query the field trial state first, to ensure that UMA reports the cor rect group. 210 // Query the field trial state first, to ensure that UMA reports the cor rect group.
211 String fieldTrialGroup = FieldTrialList.findFullName(ICON_NTP_FIELD_TRIA L_NAME); 211 String fieldTrialGroup = FieldTrialList.findFullName(ICON_NTP_FIELD_TRIA L_NAME);
212 CommandLine commandLine = CommandLine.getInstance(); 212 CommandLine commandLine = CommandLine.getInstance();
213 if (commandLine.hasSwitch(ApplicationSwitches.DISABLE_ICON_NTP)) return false; 213 if (commandLine.hasSwitch(ChromeSwitches.DISABLE_ICON_NTP)) return false ;
214 if (commandLine.hasSwitch(ApplicationSwitches.ENABLE_ICON_NTP)) return t rue; 214 if (commandLine.hasSwitch(ChromeSwitches.ENABLE_ICON_NTP)) return true;
215 return fieldTrialGroup.equals(ICON_NTP_ENABLED_GROUP); 215 return fieldTrialGroup.equals(ICON_NTP_ENABLED_GROUP);
216 } 216 }
217 217
218 /** 218 /**
219 * Initializes the NTP. This must be called immediately after inflation, bef ore this object is 219 * Initializes the NTP. This must be called immediately after inflation, bef ore this object is
220 * used in any other way. 220 * used in any other way.
221 * 221 *
222 * @param manager NewTabPageManager used to perform various actions when the user interacts 222 * @param manager NewTabPageManager used to perform various actions when the user interacts
223 * with the page. 223 * with the page.
224 * @param isSingleUrlBarMode Whether the NTP is in single URL bar mode. 224 * @param isSingleUrlBarMode Whether the NTP is in single URL bar mode.
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
952 } 952 }
953 953
954 @Override 954 @Override
955 public void onLoadingComplete() { 955 public void onLoadingComplete() {
956 RecordHistogram.recordCount100Histogram("NewTabPage.IconsGray", mNum GrayIcons); 956 RecordHistogram.recordCount100Histogram("NewTabPage.IconsGray", mNum GrayIcons);
957 RecordHistogram.recordCount100Histogram("NewTabPage.IconsColor", mNu mColorIcons); 957 RecordHistogram.recordCount100Histogram("NewTabPage.IconsColor", mNu mColorIcons);
958 RecordHistogram.recordCount100Histogram("NewTabPage.IconsReal", mNum RealIcons); 958 RecordHistogram.recordCount100Histogram("NewTabPage.IconsReal", mNum RealIcons);
959 } 959 }
960 } 960 }
961 } 961 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698