Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1155113004: Merge ApplicationSwitches.java and ChromeSwitches.java (Closed)

Created:
5 years, 7 months ago by pkotwicz
Modified:
5 years, 7 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge ApplicationSwitches.java and ChromeSwitches.java BUG=492010 TEST=None Committed: https://crrev.com/a614537b07ed8bb3e6778ecb106937bfbd4e10f4 Cr-Commit-Position: refs/heads/master@{#331398}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -42 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 2 chunks +23 lines, -0 lines 1 comment Download
D chrome/android/java_staging/src/org/chromium/chrome/browser/ApplicationSwitches.java View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
newt@ PTAL
5 years, 7 months ago (2015-05-26 02:51:29 UTC) #5
newt (away)
lgtm after comment. Thanks! https://codereview.chromium.org/1155113004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java (right): https://codereview.chromium.org/1155113004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java#newcode99 chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java:99: public static final String DISABLE_READER_MODE_BOTTOM_BAR ...
5 years, 7 months ago (2015-05-26 14:14:04 UTC) #6
pkotwicz
I'd rather keep the switches separate. Although both of the switches are related to reader ...
5 years, 7 months ago (2015-05-26 15:00:53 UTC) #7
newt (away)
On 2015/05/26 15:00:53, pkotwicz wrote: > I'd rather keep the switches separate. Although both of ...
5 years, 7 months ago (2015-05-26 15:31:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155113004/60001
5 years, 7 months ago (2015-05-26 16:02:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 7 months ago (2015-05-26 18:21:45 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 18:22:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a614537b07ed8bb3e6778ecb106937bfbd4e10f4
Cr-Commit-Position: refs/heads/master@{#331398}

Powered by Google App Engine
This is Rietveld 408576698