Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: tests/run_test_cases_smoke_test.py

Issue 11550013: Have run_test_cases.py always print test output for failures. (Closed) Base URL: https://git.chromium.org/git/chromium/tools/swarm_client.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « run_test_cases.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/run_test_cases_smoke_test.py
diff --git a/tests/run_test_cases_smoke_test.py b/tests/run_test_cases_smoke_test.py
index 22580917dfb1744364d7187b0efc70d4dd9d2fdc..3379d50d192e9a3a54edee329bb9db51c8a3d4f9 100755
--- a/tests/run_test_cases_smoke_test.py
+++ b/tests/run_test_cases_smoke_test.py
@@ -224,14 +224,7 @@ class RunTestCases(unittest.TestCase):
self.assertEqual(1, return_code)
- expected_out_re = [
- r'\[1/\d\] \d\.\d\ds .+',
- r'\[2/\d\] \d\.\d\ds .+',
- r'\[3/\d\] \d\.\d\ds .+',
- r'\[4/\d\] \d\.\d\ds .+',
- # Retries
- r'\[5/\d\] \d\.\d\ds .+ retry \#1',
- r'\[6/\d\] \d\.\d\ds .+ retry \#2',
+ test_failure_output = [
re.escape('Note: Google Test filter = Baz.Fail'),
r'',
] + [
@@ -244,6 +237,19 @@ class RunTestCases(unittest.TestCase):
] + [
'',
'',
+ ]
+
+ expected_out_re = [
+ r'\[1/\d\] \d\.\d\ds .+',
+ r'\[2/\d\] \d\.\d\ds .+',
+ r'\[3/\d\] \d\.\d\ds .+',
+ r'\[4/\d\] \d\.\d\ds .+',
+ ] + test_failure_output + [
+ # Retries
+ r'\[5/\d\] \d\.\d\ds .+ retry \#1',
+ ] + test_failure_output + [
+ r'\[6/\d\] \d\.\d\ds .+ retry \#2',
+ ] + test_failure_output + [
re.escape('Failed tests:'),
re.escape(' Baz.Fail'),
re.escape('Summary:'),
« no previous file with comments | « run_test_cases.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698