Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: run_test_cases.py

Issue 11550013: Have run_test_cases.py always print test output for failures. (Closed) Base URL: https://git.chromium.org/git/chromium/tools/swarm_client.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/run_test_cases_smoke_test.py » ('j') | tests/run_test_cases_smoke_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: run_test_cases.py
diff --git a/run_test_cases.py b/run_test_cases.py
index 676e102db423b01eef13a81d01d21d09a468b1d4..942ac0b687c2c0c67e966b3cb9523c297b6db1d9 100755
--- a/run_test_cases.py
+++ b/run_test_cases.py
@@ -602,10 +602,10 @@ class Runner(object):
line = '%s (%.2fs) - retry #%d' % (test_case, duration, try_count)
else:
line = '%s (%.2fs)' % (test_case, duration)
- if self.verbose or (not need_to_retry and returncode):
+ if self.verbose or returncode:
# Print output in one of two cases:
- # --verbose was specified
- # If can't retry but failed.
+ # --verbose was specified.
+ # The test failed.
line += '\n' + output
self.progress.update_item(line, True, need_to_retry)
« no previous file with comments | « no previous file | tests/run_test_cases_smoke_test.py » ('j') | tests/run_test_cases_smoke_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698