Combine mask texture parameters into single gfx::RectF

Combine mask texture parameters into single gfx::RectF

This folds the 4 floats together into a single parameter to be slightly easier to manage, but doesn't change the logic.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172825

[jamesr, 2012-12-12 07:43:09]

I'm not 100% sure this makes sense.  The x/y offsets definitely make sense as
the .x/.y on a rect, but the width/height here appear to be a scale and not
necessarily reflecting a bottom/right point in any logical space (or maybe they
do?)

[jamesr, 2012-12-12 23:30:55]

Talking with Dana this is definitely better than what's there before, even if we
decide to edit it further.

cdn@ - could you review the cc_messages.h change?

[danakj, 2012-12-13 00:10:05]

LGTM with some nits

https://codereview.chromium.org/11543013/diff/1/cc/draw_quad_unittest.cc
File cc/draw_quad_unittest.cc (right):

https://codereview.chromium.org/11543013/diff/1/cc/draw_quad_unittest.cc#newc...
cc/draw_quad_unittest.cc:289: EXPECT_EQ(maskUVRect, copyQuad->mask_uv_rect);
compare the rect .ToString()s or use EXPECT_FLOAT_RECT_EQ

https://codereview.chromium.org/11543013/diff/1/cc/draw_quad_unittest.cc#newc...
cc/draw_quad_unittest.cc:297: EXPECT_EQ(maskUVRect, copyQuad->mask_uv_rect);
same

https://codereview.chromium.org/11543013/diff/1/cc/render_surface_impl.cc
File cc/render_surface_impl.cc (right):

https://codereview.chromium.org/11543013/diff/1/cc/render_surface_impl.cc#new...
cc/render_surface_impl.cc:230: mask_uv_rect.set_width(contentRect().width() /
maskLayer->contentsScaleX() / maskLayer->bounds().width());
i think this would be nicer like

mask_uv_rect = gfx::RectF(
    all,
    of,
    these,
    things);

Kinda dislike using geometry class setters, pkasting would like to remove
most/all of them even.

https://codereview.chromium.org/11543013/diff/1/content/common/cc_messages_un...
File content/common/cc_messages_unittest.cc (right):

https://codereview.chromium.org/11543013/diff/1/content/common/cc_messages_un...
content/common/cc_messages_unittest.cc:132: EXPECT_EQ(a->mask_uv_rect,
b->mask_uv_rect);
compare the .ToString()s here please

[jamesr, 2012-12-13 00:36:25]

OK, got those.

piman@ - could you review for content/common/ owners?

[piman, 2012-12-13 00:38:37]

LGTM

[Cris Neckar, 2012-12-13 01:06:01]

ipc changes lgtm

[commit-bot: I haz the power, 2012-12-13 01:12:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11543013/7001

[commit-bot: I haz the power, 2012-12-13 05:12:22]

Change committed as 172825