Issue 11543007: Add usage to explainer build script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11543007: Add usage to explainer build script (Closed)

Created:
8 years ago by Siggi Cherem (dart-lang)

Modified:
8 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/web-ui.git@master

Visibility:
Public.

More Reviews

Description

Add usage to explainer build script Committed: https://github.com/dart-lang/web-ui/commit/93ea052

Patch Set 2 : #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	example/explainer/build_examples.dart	View	1	1 chunk	+8 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://chromiumcodereview.appspot.com/11543007/diff/2001/example/explainer/build_examples.dart File example/explainer/build_examples.dart (right): https://chromiumcodereview.appspot.com/11543007/diff/2001/example/explainer/build_examples.dart#newcode19 example/explainer/build_examples.dart:19: help: 'Displayes this help message', defaultsTo:false, negatable: false); ...

8 years ago (2012-12-12 02:02:03 UTC) #2

Siggi Cherem (dart-lang)

8 years ago (2012-12-13 18:05:23 UTC) #3

https://chromiumcodereview.appspot.com/11543007/diff/2001/example/explainer/b...
File example/explainer/build_examples.dart (right):

https://chromiumcodereview.appspot.com/11543007/diff/2001/example/explainer/b...
example/explainer/build_examples.dart:19: help: 'Displayes this help message',
defaultsTo:false, negatable: false);
On 2012/12/12 02:02:03, John Messerly wrote:
> nit, missing space in "defaultsTo:false" (and corresponding line wrap). it
might
> fit like this:
> 
>   argParser.addFlag('help', abbr: 'h', help: 'Displayes this help message',
>       defaultsTo: false, negatable: false);

Done.

Expand Messages | Collapse Messages

Issue 11543007: Add usage to explainer build script (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages