Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 11543007: Add usage to explainer build script (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
2 years, 4 months ago
Reviewers:
John Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Add usage to explainer build script Committed: https://github.com/dart-lang/web-ui/commit/93ea052

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M example/explainer/build_examples.dart View 1 1 chunk +8 lines, -0 lines 2 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
2 years, 4 months ago (2012-12-12 00:16:18 UTC) #1
John Messerly
lgtm https://chromiumcodereview.appspot.com/11543007/diff/2001/example/explainer/build_examples.dart File example/explainer/build_examples.dart (right): https://chromiumcodereview.appspot.com/11543007/diff/2001/example/explainer/build_examples.dart#newcode19 example/explainer/build_examples.dart:19: help: 'Displayes this help message', defaultsTo:false, negatable: false); ...
2 years, 4 months ago (2012-12-12 02:02:03 UTC) #2
Siggi Cherem (dart-lang)
2 years, 4 months ago (2012-12-13 18:05:23 UTC) #3
https://chromiumcodereview.appspot.com/11543007/diff/2001/example/explainer/b...
File example/explainer/build_examples.dart (right):

https://chromiumcodereview.appspot.com/11543007/diff/2001/example/explainer/b...
example/explainer/build_examples.dart:19: help: 'Displayes this help message',
defaultsTo:false, negatable: false);
On 2012/12/12 02:02:03, John Messerly wrote:
> nit, missing space in "defaultsTo:false" (and corresponding line wrap). it
might
> fit like this:
> 
>   argParser.addFlag('help', abbr: 'h', help: 'Displayes this help message',
>       defaultsTo: false, negatable: false);

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 700cc9d