Add operator==, hashCode, and toString for Rect and Point dart classes.

Add operator==, hashCode, and toString for Rect, Point, and Size dart classes.

R=abarth@chromium.org, sethladd@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/bc26101adc58c1c6e4da1f5ef8e1ce57f0d56b8c

[Matt Perry, 2015-05-27 21:55:32]

mpcomplete@chromium.org changed reviewers:
+ sethladd@google.com

[sethladd, 2015-05-27 22:05:21]

lgtm with some comments

[sethladd, 2015-05-27 22:19:50]

https://chromiumcodereview.appspot.com/1154213005/diff/1/sky/engine/core/pain...
File sky/engine/core/painting/Point.dart (right):

https://chromiumcodereview.appspot.com/1154213005/diff/1/sky/engine/core/pain...
sky/engine/core/painting/Point.dart:7: class Point {
If yall are adding comments, here's a good place to add a comment.

Use the /// style of comments.

See also https://www.dartlang.org/articles/doc-comment-guidelines/

https://chromiumcodereview.appspot.com/1154213005/diff/1/sky/engine/core/pain...
sky/engine/core/painting/Point.dart:11: Point(this.x, this.y);
did you want to throw if x or y are null?

https://chromiumcodereview.appspot.com/1154213005/diff/1/sky/engine/core/pain...
sky/engine/core/painting/Point.dart:23: String toString() {
not sure about your project's style, but this could be:

String toString() => "Point($x, $y)";

https://chromiumcodereview.appspot.com/1154213005/diff/1/sky/engine/core/pain...
File sky/engine/core/painting/Rect.dart (right):

https://chromiumcodereview.appspot.com/1154213005/diff/1/sky/engine/core/pain...
sky/engine/core/painting/Rect.dart:14: void setLTRB(double left, double top,
double right, double bottom) {
Dart has named constructors. You could do:

Rect.LTRB(double left, double top, double right, double bottom) {
  _value = new Float32List.fromList([left, top, right, bottom]);
}

https://chromiumcodereview.appspot.com/1154213005/diff/1/sky/engine/core/pain...
sky/engine/core/painting/Rect.dart:29: String toString() {
consider using => here

[Matt Perry, 2015-05-28 17:05:54]

https://codereview.chromium.org/1154213005/diff/1/sky/engine/core/painting/Po...
File sky/engine/core/painting/Point.dart (right):

https://codereview.chromium.org/1154213005/diff/1/sky/engine/core/painting/Po...
sky/engine/core/painting/Point.dart:7: class Point {
On 2015/05/27 22:19:49, sethladd wrote:
> If yall are adding comments, here's a good place to add a comment.
> 
> Use the /// style of comments.
> 
> See also https://www.dartlang.org/articles/doc-comment-guidelines/

Done.

https://codereview.chromium.org/1154213005/diff/1/sky/engine/core/painting/Po...
sky/engine/core/painting/Point.dart:11: Point(this.x, this.y);
On 2015/05/27 22:19:49, sethladd wrote:
> did you want to throw if x or y are null?

Good question... not sure what behavior I want here.

https://codereview.chromium.org/1154213005/diff/1/sky/engine/core/painting/Po...
sky/engine/core/painting/Point.dart:23: String toString() {
On 2015/05/27 22:19:49, sethladd wrote:
> not sure about your project's style, but this could be:
> 
> String toString() => "Point($x, $y)";

Done.

https://codereview.chromium.org/1154213005/diff/1/sky/engine/core/painting/Re...
File sky/engine/core/painting/Rect.dart (right):

https://codereview.chromium.org/1154213005/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:14: void setLTRB(double left, double top,
double right, double bottom) {
On 2015/05/27 22:19:49, sethladd wrote:
> Dart has named constructors. You could do:
> 
> Rect.LTRB(double left, double top, double right, double bottom) {
>   _value = new Float32List.fromList([left, top, right, bottom]);
> }

Done.

https://codereview.chromium.org/1154213005/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:29: String toString() {
On 2015/05/27 22:19:49, sethladd wrote:
> consider using => here

Done.

[abarth-chromium, 2015-05-28 17:06:13]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-05-28 17:06:13]

lgtm

[sethladd, 2015-05-28 17:09:03]

https://codereview.chromium.org/1154213005/diff/40001/sky/engine/core/paintin...
File sky/engine/core/painting/Rect.dart (right):

https://codereview.chromium.org/1154213005/diff/40001/sky/engine/core/paintin...
sky/engine/core/painting/Rect.dart:9: Float32List _value;
you could initialize this value here.

Float32List _value = new Float32List(4);

(consider making it final)

Then, you don't need to initialize it in all of your constructors.

[Matt Perry, 2015-05-28 17:25:06]

Thanks for the detailed review!

https://codereview.chromium.org/1154213005/diff/40001/sky/engine/core/paintin...
File sky/engine/core/painting/Rect.dart (right):

https://codereview.chromium.org/1154213005/diff/40001/sky/engine/core/paintin...
sky/engine/core/painting/Rect.dart:9: Float32List _value;
On 2015/05/28 17:09:03, sethladd wrote:
> you could initialize this value here.
> 
> Float32List _value = new Float32List(4);
> 
> (consider making it final)
> 
> Then, you don't need to initialize it in all of your constructors.

Done.

[sethladd, 2015-05-28 17:27:38]

https://codereview.chromium.org/1154213005/diff/60001/sky/engine/core/paintin...
File sky/engine/core/painting/Rect.dart (right):

https://codereview.chromium.org/1154213005/diff/60001/sky/engine/core/paintin...
sky/engine/core/painting/Rect.dart:18: _value[0] = point.x
you may want to move this down to:

  ..[0] = point.x

to be consistent with setLTRB

[Matt Perry, 2015-05-28 17:29:44]

https://codereview.chromium.org/1154213005/diff/60001/sky/engine/core/paintin...
File sky/engine/core/painting/Rect.dart (right):

https://codereview.chromium.org/1154213005/diff/60001/sky/engine/core/paintin...
sky/engine/core/painting/Rect.dart:18: _value[0] = point.x
On 2015/05/28 17:27:37, sethladd wrote:
> you may want to move this down to:
> 
>   ..[0] = point.x
> 
> to be consistent with setLTRB

Yep! Thanks. Actually, it doesn't work the way it's written now. I think if you
write
  _value[0] = x .. [1] = y;
then the cascade operator is applying to _value[0] instead of _value.

[Matt Perry, 2015-05-28 17:33:09]

Committed patchset #4 (id:60001) manually as
bc26101adc58c1c6e4da1f5ef8e1ce57f0d56b8c (presubmit successful).