Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: vm/flow_graph_builder.cc

Issue 11519006: Add read only handles for the following predefined symbols (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« vm/ast.h ('K') | « vm/dart_entry.cc ('k') | vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_builder.cc
===================================================================
--- vm/flow_graph_builder.cc (revision 15920)
+++ vm/flow_graph_builder.cc (working copy)
@@ -2368,11 +2368,9 @@
Function* super_function = NULL;
if (node->IsSuperLoad()) {
// Resolve the load indexed operator in the super class.
- const String& index_operator_name =
- String::ZoneHandle(Symbols::IndexToken());
super_function = &Function::ZoneHandle(
Resolver::ResolveDynamicAnyArgs(node->super_class(),
- index_operator_name));
+ Symbols::IndexTokenHandle()));
if (super_function->IsNull()) {
// Could not resolve super operator. Generate call noSuchMethod() of the
// super class instead.
@@ -2381,7 +2379,7 @@
StaticCallInstr* call =
BuildStaticNoSuchMethodCall(node->super_class(),
node->array(),
- index_operator_name,
+ Symbols::IndexTokenHandle(),
arguments);
ReturnDefinition(call);
return;
@@ -2409,9 +2407,8 @@
} else {
// Generate dynamic call to index operator.
const intptr_t checked_argument_count = 1;
- const String& name = String::ZoneHandle(Symbols::IndexToken());
InstanceCallInstr* load = new InstanceCallInstr(node->token_pos(),
- name,
+ Symbols::IndexTokenHandle(),
Token::kINDEX,
arguments,
Array::ZoneHandle(),
@@ -2427,11 +2424,9 @@
Function* super_function = NULL;
if (node->IsSuperStore()) {
// Resolve the store indexed operator in the super class.
- const String& store_index_op_name =
- String::ZoneHandle(Symbols::AssignIndexToken());
super_function = &Function::ZoneHandle(
Resolver::ResolveDynamicAnyArgs(node->super_class(),
- store_index_op_name));
+ Symbols::AssignIndexTokenHandle()));
if (super_function->IsNull()) {
// Could not resolve super operator. Generate call noSuchMethod() of the
// super class instead.
@@ -2449,7 +2444,7 @@
StaticCallInstr* call =
BuildStaticNoSuchMethodCall(node->super_class(),
node->array(),
- store_index_op_name,
+ Symbols::AssignIndexTokenHandle(),
arguments);
if (result_is_needed) {
Do(call);
« vm/ast.h ('K') | « vm/dart_entry.cc ('k') | vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698