Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 11519006: Add read only handles for the following predefined symbols (Closed)

Created:
8 years ago by siva
Modified:
8 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add read only handles for the following predefined symbols "==" "[]" "[]=" "this" and use them in the code. Committed: https://code.google.com/p/dart/source/detail?r=15942

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -56 lines) Patch
M vm/assembler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/assembler_ia32.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M vm/assembler_x64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M vm/ast.h View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/dart_api_impl.cc View 4 chunks +24 lines, -16 lines 0 comments Download
M vm/dart_entry.cc View 2 chunks +1 line, -2 lines 0 comments Download
M vm/flow_graph_builder.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M vm/intermediate_language.h View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/intermediate_language_ia32.cc View 2 chunks +1 line, -2 lines 0 comments Download
M vm/intermediate_language_x64.cc View 2 chunks +1 line, -2 lines 0 comments Download
M vm/object.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M vm/object.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M vm/parser.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M vm/scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M vm/stub_code_ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M vm/stub_code_x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M vm/symbols.h View 2 chunks +6 lines, -0 lines 0 comments Download
M vm/symbols.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years ago (2012-12-10 21:51:26 UTC) #1
srdjan
LGTM. As discussed, in a future CL remove all predefined raw pointer in Symbols so ...
8 years ago (2012-12-10 22:15:43 UTC) #2
siva
8 years ago (2012-12-11 01:03:49 UTC) #3
Yes, Once we are done with migrating all the predefined
symbols to Handle versions we can remove the accessors to
the Raw versions.

https://chromiumcodereview.appspot.com/11519006/diff/1/vm/ast.h
File vm/ast.h (right):

https://chromiumcodereview.appspot.com/11519006/diff/1/vm/ast.h#newcode306
vm/ast.h:306: ASSERT(literal_.IsPredefinedHandle() || literal_.IsZoneHandle());
I have merged the test into one function and called it
IsNotTemporaryScopedHandle()

On 2012/12/10 22:15:44, srdjan wrote:
> Do you want to merge that frequent test? It is going to be very frequent
> (wherever we accept ZoneHandles, predefined handles are OK as well)

Powered by Google App Engine
This is Rietveld 408576698