vm/ast.h - Issue 11519006: Add read only handles for the following predefined symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/ast.h

Issue 11519006: Add read only handles for the following predefined symbols (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/ast.h

===================================================================

--- vm/ast.h (revision 15918)

+++ vm/ast.h (working copy)

@@ -303,7 +303,7 @@

public:

LiteralNode(intptr_t token_pos, const Instance& literal)

: AstNode(token_pos), literal_(literal) {

- ASSERT(literal_.IsZoneHandle());

+ ASSERT(literal_.IsPredefinedHandle() || literal_.IsZoneHandle());

srdjan 2012/12/10 22:15:44 Do you want to merge that frequent test? It is goi

siva 2012/12/11 01:03:49 I have merged the test into one function and calle

ASSERT(literal_.IsSmi() || literal_.IsOld());

#if defined(DEBUG)

if (literal_.IsString()) {

« no previous file with comments | « vm/assembler_x64.cc ('k') | vm/dart_api_impl.cc » ('j') | no next file with comments »