vm/assembler_ia32.cc - Issue 11519006: Add read only handles for the following predefined symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/assembler_ia32.cc

Issue 11519006: Add read only handles for the following predefined symbols (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/assembler_ia32.cc

===================================================================

--- vm/assembler_ia32.cc (revision 15918)

+++ vm/assembler_ia32.cc (working copy)

@@ -1554,7 +1554,7 @@

if (object.IsSmi() || object.IsNull()) {

movl(dst, Immediate(reinterpret_cast<int32_t>(object.raw())));

} else {

- ASSERT(object.IsZoneHandle());

+ ASSERT(object.IsPredefinedHandle() || object.IsZoneHandle());

ASSERT(object.IsOld());

AssemblerBuffer::EnsureCapacity ensured(&buffer_);

EmitUint8(0xB8 + dst);

@@ -1567,7 +1567,7 @@

if (object.IsSmi() || object.IsNull()) {

pushl(Immediate(reinterpret_cast<int32_t>(object.raw())));

} else {

- ASSERT(object.IsZoneHandle());

+ ASSERT(object.IsPredefinedHandle() || object.IsZoneHandle());

ASSERT(object.IsOld());

AssemblerBuffer::EnsureCapacity ensured(&buffer_);

EmitUint8(0x68);

@@ -1580,7 +1580,7 @@

if (object.IsSmi() || object.IsNull()) {

cmpl(reg, Immediate(reinterpret_cast<int32_t>(object.raw())));

} else {

- ASSERT(object.IsZoneHandle());

+ ASSERT(object.IsPredefinedHandle() || object.IsZoneHandle());

ASSERT(object.IsOld());

AssemblerBuffer::EnsureCapacity ensured(&buffer_);

if (reg == EAX) {

« no previous file with comments | « vm/assembler.cc ('k') | vm/assembler_x64.cc » ('j') | vm/ast.h » ('J')