Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 11516005: cc: Handle directly composited images in impl-side painting (Closed)

Created:
8 years ago by enne (OOO)
Modified:
8 years ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, jamesr
Visibility:
Public.

Description

cc: Handle directly composited images in impl-side painting Directly composited images are recorded into an SkPicture just like normal content. This also means that (at the moment) they will be treated like normal content, such as getting low-res versions. There will need to be some future follow-up to make sure that tiny images that end up large on page don't take up unnecessary GPU memory. The only bad part about this path is that changing a layer's bounds forces the content to need to be re-recorded and re-rasterized, as there's an assumption that the composited image fills its entire bounds. This could be fixed in the future by adding another layer (haha) of indirection. R=nduca@chromium.org BUG=163998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172241

Patch Set 1 #

Patch Set 2 : Fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -4 lines) Patch
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/content_layer_client.h View 1 2 chunks +3 lines, -1 line 0 comments Download
A cc/picture_image_layer.h View 1 chunk +44 lines, -0 lines 0 comments Download
A cc/picture_image_layer.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_image_layer_impl.cc View 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
8 years ago (2012-12-10 20:03:57 UTC) #1
nduca
lgtmnomnomnom
8 years ago (2012-12-10 21:36:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11516005/1
8 years ago (2012-12-10 22:01:41 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-10 23:06:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11516005/1003
8 years ago (2012-12-10 23:26:33 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-11 02:26:54 UTC) #6
Message was sent while issue was closed.
Change committed as 172241

Powered by Google App Engine
This is Rietveld 408576698