Add LayoutTest for the script error sanitization for ServiceWorker fetched scripts.

Add LayoutTest for the script error sanitization for ServiceWorker fetched scripts.

BUG=483488
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195902

[horo, 2015-05-25 08:30:17]

Patchset #1 (id:1) has been deleted

[horo, 2015-05-25 08:30:48]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2015-05-25 08:30:48]

falken@
Could you please review this?

[falken, 2015-05-26 01:23:35]

I think this makes more sense as chromium/ test, WDYT?

s/SerivceWorker/SerivceWorker in the CL description

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/fetch-script-onerror.html (right):

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-script-onerror.html:18:
frame.contentWindow.postMessage({url: url}, host_info['HTTP_ORIGIN'])
nit: missing semicolon

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-script-onerror.html:22: function
check_script_error(frame, url, shuold_be_sanitized) {
nit: s/shuold/should

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-script-onerror.html:29:
assert_equals(data.message, 'Script error.');
I don't think this message will be the same across browsers.

I think it's actually OK to make a chromium/ test since it tests error messages
which are browser-specific and not spec'd.

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/resources/fetch-script-onerror.php
(right):

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/fetch-script-onerror.php:5:
SampleData
Perhaps "UndefinedReference" to make it clearer what's going on?

[horo, 2015-05-26 03:12:14]

Moved to chromium/.

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/fetch-script-onerror.html (right):

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-script-onerror.html:18:
frame.contentWindow.postMessage({url: url}, host_info['HTTP_ORIGIN'])
On 2015/05/26 01:23:35, falken wrote:
> nit: missing semicolon

Done.

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-script-onerror.html:22: function
check_script_error(frame, url, shuold_be_sanitized) {
On 2015/05/26 01:23:35, falken wrote:
> nit: s/shuold/should

Done.

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-script-onerror.html:29:
assert_equals(data.message, 'Script error.');
On 2015/05/26 01:23:35, falken wrote:
> I don't think this message will be the same across browsers.
> 
> I think it's actually OK to make a chromium/ test since it tests error
messages
> which are browser-specific and not spec'd.

Done.

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/resources/fetch-script-onerror.php
(right):

https://codereview.chromium.org/1151433002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/fetch-script-onerror.php:5:
SampleData
On 2015/05/26 01:23:35, falken wrote:
> Perhaps "UndefinedReference" to make it clearer what's going on?

Done.

[falken, 2015-05-26 03:27:41]

lgtm

https://codereview.chromium.org/1151433002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/chromium/fetch-script-onerror.html
(right):

https://codereview.chromium.org/1151433002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/chromium/fetch-script-onerror.html:8: var
messageCallback;
nit: message_callback

[horo, 2015-05-26 03:58:41]

Thank you

https://codereview.chromium.org/1151433002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/chromium/fetch-script-onerror.html
(right):

https://codereview.chromium.org/1151433002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/chromium/fetch-script-onerror.html:8: var
messageCallback;
On 2015/05/26 03:27:41, falken wrote:
> nit: message_callback

Done.

[horo, 2015-05-26 05:13:07]

The CQ bit was checked by horo@chromium.org

[horo, 2015-05-26 05:13:08]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1151433002/#ps60001
(title: "s/messageCallback/message_callback")

[commit-bot: I haz the power, 2015-05-26 05:13:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151433002/60001

[commit-bot: I haz the power, 2015-05-26 09:08:51]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195902