chrome/browser/ui/android/infobars/infobar_android.h - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/infobar_android.h

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc ('k') | chrome/browser/ui/android/infobars/infobar_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/infobar_android.h

diff --git a/chrome/browser/ui/android/infobars/infobar_android.h b/chrome/browser/ui/android/infobars/infobar_android.h

index 8070753b00fcd500340077bae76925c0a761326f..ea36813d8f95d567f1ab3740d17d8ba076a73ef5 100644

--- a/chrome/browser/ui/android/infobars/infobar_android.h

+++ b/chrome/browser/ui/android/infobars/infobar_android.h

@@ -44,7 +44,9 @@ class InfoBarAndroid : public infobars::InfoBar {

virtual base::android::ScopedJavaLocalRef<jobject> CreateRenderInfoBar(

JNIEnv* env) = 0;

- void set_java_infobar(const base::android::JavaRef<jobject>& java_info_bar);

+ virtual void SetJavaInfoBar(

+ const base::android::JavaRef<jobject>& java_info_bar);

+ jobject GetJavaInfoBar();

bool HasSetJavaInfoBar() const;

// Tells the Java-side counterpart of this InfoBar to point to the replacement

@@ -74,6 +76,7 @@ class InfoBarAndroid : public infobars::InfoBar {

virtual void ProcessButton(int action,

const std::string& action_value) = 0;

void CloseInfoBar();

+ InfoBarAndroid* infobar_android() { return this; }

private:

base::android::ScopedJavaGlobalRef<jobject> java_info_bar_;