chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/download_overwrite_infobar.cc ('k') | chrome/browser/ui/android/infobars/infobar_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc

diff --git a/chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc b/chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc

index 2412b69b6f865a43e2dd8738a25fc13d9874bdbe..823ee04e0fec98f374985f0ec4465ec6f93d3512 100644

--- a/chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc

+++ b/chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc

@@ -33,7 +33,7 @@ GeneratedPasswordSavedInfoBar::CreateRenderInfoBar(JNIEnv* env) {

static_cast<GeneratedPasswordSavedInfoBarDelegateAndroid*>(delegate());

return Java_GeneratedPasswordSavedInfoBarDelegate_show(

- env, reinterpret_cast<intptr_t>(this), GetEnumeratedIconId(),

+ env, GetEnumeratedIconId(),

base::android::ConvertUTF16ToJavaString(

env, infobar_delegate->message_text()).obj(),

infobar_delegate->inline_link_range().start(),