Source/wtf/Compiler.h - Issue 114933002: [POSSIBLE PERFORMANCE IMPACT] Use __builtin_expect on Clang as well (for UNLIKELY and LIKELY)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/Compiler.h

Issue 114933002: [POSSIBLE PERFORMANCE IMPACT] Use __builtin_expect on Clang as well (for UNLIKELY and LIKELY) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/wtf/Compiler.h

diff --git a/Source/wtf/Compiler.h b/Source/wtf/Compiler.h

index f5ede42f9f46da5a94a488ab1393475c5dbbe292..9c76897555854c5b642652bc8a67f4f88d7cece4 100644

--- a/Source/wtf/Compiler.h

+++ b/Source/wtf/Compiler.h

@@ -153,7 +153,7 @@

/* UNLIKELY */

#ifndef UNLIKELY

-#if COMPILER(GCC)

+#if COMPILER(GCC) || COMPILER(CLANG)

#define UNLIKELY(x) __builtin_expect((x), 0)

#else

#define UNLIKELY(x) (x)

@@ -164,7 +164,7 @@

/* LIKELY */

#ifndef LIKELY

-#if COMPILER(GCC)

+#if COMPILER(GCC) || COMPILER(CLANG)

#define LIKELY(x) __builtin_expect((x), 1)

#else

#define LIKELY(x) (x)

« no previous file with comments | « no previous file | no next file » | no next file with comments »