Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Side by Side Diff: Source/wtf/Compiler.h

Issue 114933002: [POSSIBLE PERFORMANCE IMPACT] Use __builtin_expect on Clang as well (for UNLIKELY and LIKELY) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 #define NEVER_INLINE __attribute__((__noinline__)) 146 #define NEVER_INLINE __attribute__((__noinline__))
147 #else 147 #else
148 #define NEVER_INLINE 148 #define NEVER_INLINE
149 #endif 149 #endif
150 #endif 150 #endif
151 151
152 152
153 /* UNLIKELY */ 153 /* UNLIKELY */
154 154
155 #ifndef UNLIKELY 155 #ifndef UNLIKELY
156 #if COMPILER(GCC) 156 #if COMPILER(GCC) || COMPILER(CLANG)
157 #define UNLIKELY(x) __builtin_expect((x), 0) 157 #define UNLIKELY(x) __builtin_expect((x), 0)
158 #else 158 #else
159 #define UNLIKELY(x) (x) 159 #define UNLIKELY(x) (x)
160 #endif 160 #endif
161 #endif 161 #endif
162 162
163 163
164 /* LIKELY */ 164 /* LIKELY */
165 165
166 #ifndef LIKELY 166 #ifndef LIKELY
167 #if COMPILER(GCC) 167 #if COMPILER(GCC) || COMPILER(CLANG)
168 #define LIKELY(x) __builtin_expect((x), 1) 168 #define LIKELY(x) __builtin_expect((x), 1)
169 #else 169 #else
170 #define LIKELY(x) (x) 170 #define LIKELY(x) (x)
171 #endif 171 #endif
172 #endif 172 #endif
173 173
174 174
175 /* NO_RETURN */ 175 /* NO_RETURN */
176 176
177 177
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 #define WTf_COMPILER_SUPPORTS_PRETTY_FUNCTION 1 268 #define WTf_COMPILER_SUPPORTS_PRETTY_FUNCTION 1
269 #define WTF_PRETTY_FUNCTION __PRETTY_FUNCTION__ 269 #define WTF_PRETTY_FUNCTION __PRETTY_FUNCTION__
270 #elif COMPILER(MSVC) 270 #elif COMPILER(MSVC)
271 #define WTf_COMPILER_SUPPORTS_PRETTY_FUNCTION 1 271 #define WTf_COMPILER_SUPPORTS_PRETTY_FUNCTION 1
272 #define WTF_PRETTY_FUNCTION __FUNCDNAME__ 272 #define WTF_PRETTY_FUNCTION __FUNCDNAME__
273 #else 273 #else
274 #define WTF_PRETTY_FUNCTION __FUNCTION__ 274 #define WTF_PRETTY_FUNCTION __FUNCTION__
275 #endif 275 #endif
276 276
277 #endif /* WTF_Compiler_h */ 277 #endif /* WTF_Compiler_h */
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698