Issue 11485019: [Sync] Add tests for invalid specifics field number handling

Issue 11485019: [Sync] Add tests for invalid specifics field number handling (Closed)

Created:
8 years ago by akalin

Modified:
8 years ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Add tests for invalid specifics field number handling This is a follow up to r172232. Change NOTREACHED() to DLOG(WARNING), since the server sending down unknown/invalid field numbers is a valid event. Add tests for the code that uses GetModelTypeFromSpecificsFieldNumber(). Clean up some code in sync/engine/ a bit. BUG=165171 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172816

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+270 lines, -131 lines)			Patch
M	sync/engine/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/engine/store_timestamps_command.h	View	1 chunk	+16 lines, -0 lines	2 comments	Download
M	sync/engine/store_timestamps_command.cc	View	1 chunk	+22 lines, -17 lines	0 comments	Download
A	sync/engine/store_timestamps_command_unittest.cc	View	1 chunk	+83 lines, -0 lines	0 comments	Download
M	sync/engine/syncer_proto_util.h	View	4 chunks	+13 lines, -8 lines	0 comments	Download
M	sync/engine/syncer_proto_util.cc	View	6 chunks	+95 lines, -100 lines	0 comments	Download
M	sync/engine/syncer_proto_util_unittest.cc	View	3 chunks	+38 lines, -5 lines	0 comments	Download
M	sync/internal_api/public/base/model_type.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sync/sync.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM https://codereview.chromium.org/11485019/diff/3001/sync/engine/store_timestamps_command.h File sync/engine/store_timestamps_command.h (right): https://codereview.chromium.org/11485019/diff/3001/sync/engine/store_timestamps_command.h#newcode26 sync/engine/store_timestamps_command.h:26: SYNC_EXPORT_PRIVATE ModelTypeSet ProcessNewProgressMarkers( Is this now necessary for ...

8 years ago (2012-12-13 01:48:20 UTC) #2

akalin

https://codereview.chromium.org/11485019/diff/3001/sync/engine/store_timestamps_command.h File sync/engine/store_timestamps_command.h (right): https://codereview.chromium.org/11485019/diff/3001/sync/engine/store_timestamps_command.h#newcode26 sync/engine/store_timestamps_command.h:26: SYNC_EXPORT_PRIVATE ModelTypeSet ProcessNewProgressMarkers( On 2012/12/13 01:48:21, Nicolas Zea wrote: ...

8 years ago (2012-12-13 01:50:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/11485019/3001

8 years ago (2012-12-13 01:51:36 UTC) #4

Message was sent while issue was closed.

Change committed as 172816

Expand Messages | Collapse Messages