sync/internal_api/public/base/model_type.h - Issue 11485019: [Sync] Add tests for invalid specifics field number handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base/model_type.h

Issue 11485019: [Sync] Add tests for invalid specifics field number handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/base/model_type.h

diff --git a/sync/internal_api/public/base/model_type.h b/sync/internal_api/public/base/model_type.h

index 327d98015a3be44f35144ce3155b2851f8ec3761..f08ce6661d3a03a0bff9b524e3bc8a49e4ef2f68 100644

--- a/sync/internal_api/public/base/model_type.h

+++ b/sync/internal_api/public/base/model_type.h

@@ -174,7 +174,7 @@ bool IsControlType(ModelType model_type);

// ModelType model_type =

// GetModelTypeFromSpecificsFieldNumber(field_number);

// if (!IsRealDataType(model_type)) {

-// NOTREACHED() << "Unknown field number " << field_number;

+// DLOG(WARNING) << "Unknown field number " << field_number;

// continue;

// }

// model_types.Put(model_type);