sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 11478022: Implement is-checks with typedefs for callable objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11478022: Implement is-checks with typedefs for callable objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

index 6beaa0c8e48e35fe0c6007fd0f61d5a8d44aa79b..53d9951a130e2b932295c09e379c7dfb30dc8642 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

@@ -2347,9 +2347,6 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

if (identical(element.kind, ElementKind.TYPE_VARIABLE)) {

compiler.unimplemented("visitIs for type variables",

instruction: node.expression);

- } else if (identical(element.kind, ElementKind.TYPEDEF)) {

- compiler.unimplemented("visitIs for typedefs",

- instruction: node.expression);

}

LibraryElement coreLibrary = compiler.coreLibrary;

ClassElement objectClass = compiler.objectClass;