sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 11478022: Implement is-checks with typedefs for callable objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 11478022: Implement is-checks with typedefs for callable objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

index 88718e143fa8eda77f055a8013b33b8a02124012..290a3579d64550222d5dcdd5f3cb88558de86b54 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

@@ -2541,7 +2541,7 @@ class HIs extends HInstruction {

HInstruction getCheck(int index) => inputs[index + 1];

int get checkCount => inputs.length - 1;

- bool hasArgumentChecks() => inputs.length >= 1;

+ bool hasArgumentChecks() => inputs.length > 1;

ngeoffray 2012/12/10 07:07:54 Is that related to this CL? Or are you fixing a bu

karlklose 2012/12/11 08:40:05 This does not show as a bug, because the code that

HType get guaranteedType => HType.BOOLEAN;