Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 11478016: Add a stat to the smoothness benchmark for avg number of missing tiles. (Closed)

Created:
8 years ago by Ian Vollick
Modified:
8 years ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, cc-bugs_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Add a stat to the smoothness benchmark for avg number of missing tiles. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171845

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M cc/append_quads_data.h View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/layer_tree_host_impl.h View 1 chunk +5 lines, -3 lines 1 comment Download
M cc/layer_tree_host_impl.cc View 3 chunks +4 lines, -1 line 0 comments Download
M cc/picture_layer_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/rendering_stats.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/rendering_stats.cc View 2 chunks +3 lines, -1 line 0 comments Download
M cc/tiled_layer_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/tiled_layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/perf_tools/smoothness_benchmark.py View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ian Vollick
nduca, can you check if I'm measuring checkerboarding correctly? hartmanng, can you please take a ...
8 years ago (2012-12-07 01:08:26 UTC) #1
nduca
lgtm but good to get quick eye from dana or enne https://codereview.chromium.org/11478016/diff/1/cc/layer_tree_host_impl.h File cc/layer_tree_host_impl.h (right): ...
8 years ago (2012-12-07 01:14:37 UTC) #2
Ian Vollick
On 2012/12/07 01:14:37, nduca wrote: > lgtm but good to get quick eye from dana ...
8 years ago (2012-12-07 01:33:24 UTC) #3
enne (OOO)
lgtm
8 years ago (2012-12-07 17:40:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/11478016/1
8 years ago (2012-12-07 17:44:21 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-07 21:40:54 UTC) #6
Message was sent while issue was closed.
Change committed as 171845

Powered by Google App Engine
This is Rietveld 408576698