Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 11474050: cc: Unify namespaces for all test files (Closed)

Created:
8 years ago by enne (OOO)
Modified:
8 years ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, cc-bugs_chromium.org, darin-cc_chromium.org, danakj
Visibility:
Public.

Description

cc: Unify namespaces for all test files All cc test harnesses now live in the cc namespace. Any cc unittest or pixeltest itself is in an anonymous namespace under cc. This patch removes all instances of the WebKitTest namespace from cc. R=jamesr@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173391

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+886 lines, -502 lines) Patch
M cc/cc_tests.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M cc/damage_tracker_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/delay_based_time_source_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/delegated_renderer_layer_impl_unittest.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M cc/frame_rate_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/gl_renderer_pixeltest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/gl_renderer_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/hash_pair_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 1 2 25 chunks +80 lines, -88 lines 0 comments Download
M cc/layer_tree_host_perftest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 1 2 3 7 chunks +9 lines, -12 lines 0 comments Download
M cc/occlusion_tracker_unittest.cc View 1 10 chunks +20 lines, -23 lines 0 comments Download
M cc/picture_layer_tiling_set_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/picture_layer_tiling_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/render_pass_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resource_update_controller_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/scrollbar_layer_unittest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M cc/software_renderer_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/solid_color_layer_impl_unittest.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M cc/test/animation_test_common.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M cc/test/cc_test_suite.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/cc_test_suite.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/compositor_fake_web_graphics_context_3d.h View 3 chunks +7 lines, -7 lines 0 comments Download
A cc/test/compositor_fake_web_graphics_context_3d.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M cc/test/fake_content_layer_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_content_layer_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_graphics_context_3d_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M cc/test/fake_layer_tree_host_client.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M cc/test/fake_output_surface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
A cc/test/fake_web_compositor_output_surface.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A cc/test/fake_web_compositor_software_output_device.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M cc/test/fake_web_graphics_context_3d.h View 1 chunk +190 lines, -204 lines 0 comments Download
A cc/test/fake_web_graphics_context_3d.cc View 1 chunk +222 lines, -0 lines 0 comments Download
M cc/test/fake_web_graphics_context_3d_unittest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M cc/test/fake_web_scrollbar_theme_geometry.h View 1 chunk +23 lines, -31 lines 0 comments Download
A cc/test/fake_web_scrollbar_theme_geometry.cc View 1 chunk +91 lines, -0 lines 0 comments Download
M cc/test/geometry_test_utils.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/geometry_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/layer_test_common.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/test/layer_test_common.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test_common.h View 1 11 chunks +23 lines, -25 lines 0 comments Download
M cc/test/layer_tree_test_common.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M cc/test/mock_quad_culler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/occlusion_tracker_test_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/paths.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/paths.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/pixel_test_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/pixel_test_utils.h View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/test/pixel_test_utils.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/test/render_pass_test_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/render_pass_test_common.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M cc/test/render_pass_test_utils.h View 1 2 1 chunk +5 lines, -8 lines 0 comments Download
M cc/test/render_pass_test_utils.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/scheduler_test_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/scheduler_test_common.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/tiled_layer_test_common.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/tiled_layer_test_common.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/tile_priority_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/tiled_layer_impl_unittest.cc View 1 5 chunks +7 lines, -10 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/compositor_bindings/test/web_layer_tree_view_test_common.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
enne (OOO)
8 years ago (2012-12-08 05:05:30 UTC) #1
enne (OOO)
...ping?
8 years ago (2012-12-14 01:25:59 UTC) #2
jamesr
lgtm sorry! this slipped my queue
8 years ago (2012-12-14 04:15:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11474050/1
8 years ago (2012-12-14 17:31:52 UTC) #4
commit-bot: I haz the power
Failed to apply patch for cc/gl_renderer_pixeltest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years ago (2012-12-14 17:32:09 UTC) #5
enne (OOO)
piman: Can I get an OWNERS review for my tiny ui/compositor change?
8 years ago (2012-12-14 18:26:27 UTC) #6
jonathan.backer
On 2012/12/14 18:26:27, enne wrote: > piman: Can I get an OWNERS review for my ...
8 years ago (2012-12-14 19:50:31 UTC) #7
piman
lgtm
8 years ago (2012-12-14 20:14:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11474050/7001
8 years ago (2012-12-14 20:17:41 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 01:09:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11474050/7001
8 years ago (2012-12-15 01:18:56 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 05:01:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11474050/7001
8 years ago (2012-12-15 22:01:58 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-15 22:28:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11474050/22001
8 years ago (2012-12-16 00:34:11 UTC) #15
commit-bot: I haz the power
Failed to apply patch for cc/scrollbar_layer_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years ago (2012-12-16 05:13:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11474050/27003
8 years ago (2012-12-16 18:00:19 UTC) #17
commit-bot: I haz the power
8 years ago (2012-12-16 20:32:16 UTC) #18
Message was sent while issue was closed.
Change committed as 173391

Powered by Google App Engine
This is Rietveld 408576698